From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 8/9]: Set per-connection CCIDs via socket options
Date: Mon, 01 Oct 2007 18:57:21 +0000 [thread overview]
Message-ID: <20071001185721.GA7881@ghostprotocols.net> (raw)
In-Reply-To: <200709281630.33024@strip-the-willow>
Em Tue, Oct 02, 2007 at 07:51:45AM +1300, Ian McDonald escreveu:
> On 9/29/07, Gerrit Renker <gerrit@erg.abdn.ac.uk> wrote:
> > [DCCP]: Set per-connection CCIDs via socket options
> >
> > With this patch, TX/RX CCIDs can now be changed on a per-connection basis, which
> > overrides the defaults set by the global sysctl variables for TX/RX CCIDs.
> >
> > To make full use of this facility, the remaining patches of this patch set are
> > needed, which track dependencies and activate negotiated feature values.
> >
> > Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
>
> Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
>
> But see one comment below.
>
> > + BUILD_BUG_ON(sizeof(u8) != 1);
>
> The whole point of u8 is that it is one byte as is u16 2 bytes etc. If
> these change then the whole kernel breaks so this check is
> unnecessary.
Agreed.
- Arnaldo
prev parent reply other threads:[~2007-10-01 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 15:30 [PATCH 8/9]: Set per-connection CCIDs via socket options Gerrit Renker
2007-10-01 18:51 ` Ian McDonald
2007-10-01 18:57 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071001185721.GA7881@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox