From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 3/3]: Convert Reset code into socket error number
Date: Tue, 02 Oct 2007 10:08:41 +0000 [thread overview]
Message-ID: <200710021108.41257@strip-the-willow> (raw)
In-Reply-To: <200709291744.53552@strip-the-willow>
| Yes you are correct. I misread the code.
|
| However - I'd prefer another constant to match last in enum at the
| same point as the declaration of the enum. This way if values are
| added other code doesn't break. I've seen this done before quite a few
| times. It is dangerous on relying on the last value when it's not
| explicitly marked as the last value.
Sorry I was replying to emails in-order and this one was later in the pile, so
please disregard most of the previous email.
Your suggestion is a useful improvement, which means that I will rework and the
resubmit.
prev parent reply other threads:[~2007-10-02 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 16:44 [PATCH 3/3]: Convert Reset code into socket error number Gerrit Renker
2007-10-01 19:38 ` Ian McDonald
2007-10-01 19:55 ` Arnaldo Carvalho de Melo
2007-10-01 20:07 ` Ian McDonald
2007-10-01 20:15 ` Arnaldo Carvalho de Melo
2007-10-02 10:04 ` Gerrit Renker
2007-10-02 10:08 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710021108.41257@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox