From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 9/14]: Phase out the use of boolean flag for Ack Vectors
Date: Thu, 04 Oct 2007 12:50:59 +0000 [thread overview]
Message-ID: <200710041350.59642@strip-the-willow> (raw)
In-Reply-To: <200710031502.47513@strip-the-willow>
Quoting Ian McDonald:
| > --- a/include/linux/dccp.h
| > +++ b/include/linux/dccp.h
| > @@ -372,7 +372,6 @@ static inline unsigned int dccp_hdr_len(
| > #define DCCPF_INITIAL_SEQUENCE_WINDOW 100
| > #define DCCPF_INITIAL_ACK_RATIO 2
| > #define DCCPF_INITIAL_CCID DCCPC_CCID2
| > -#define DCCPF_INITIAL_SEND_ACK_VECTOR 1
| > /* FIXME: for now we're default to 1 but it should really be 0 */
| > #define DCCPF_INITIAL_SEND_NDP_COUNT 1
| >
| Not sure if the fixme applies to ack_vector or send_ndp_count so
| unsure if that should be removed also.
Well spotted - the FIXME applies to NDP count, both lines are removed in
[PATCH 13/14]: Initialisation and type-checking of feature sysctls
which has the following hunk:
@@ -368,13 +368,6 @@ static inline unsigned int dccp_hdr_len(
}
-/* initial values for each feature */
-#define DCCPF_INITIAL_SEQUENCE_WINDOW 100
-#define DCCPF_INITIAL_ACK_RATIO 2
-#define DCCPF_INITIAL_CCID DCCPC_CCID2
-/* FIXME: for now we're default to 1 but it should really be 0 */
-#define DCCPF_INITIAL_SEND_NDP_COUNT 1
-
The hardcoded constants are replaced by looking up the default value for the feature
in the feat.c-lookup table (which itself has the defaults from 6.4).
Changes from global settings can be enforced by setting socket options.
prev parent reply other threads:[~2007-10-04 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 14:02 [PATCH 9/14]: Phase out the use of boolean flag for Ack Vectors Gerrit Renker
2007-10-03 21:05 ` Ian McDonald
2007-10-04 12:50 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710041350.59642@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox