DCCP protocol discussions
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 5/14]: Clean up remains from old feature-negotiation infrastructure
Date: Thu, 04 Oct 2007 13:08:37 +0000	[thread overview]
Message-ID: <200710041408.37460@strip-the-willow> (raw)
In-Reply-To: <200710031502.38598@strip-the-willow>

|  Your code doesn't quite match your description as removing one line of
|  code from a function. I'm assuming this is OK but raising it just in
|  case.
|  
Thanks - I have put the hunk below into the earlier patch 
	
	"[DCCP]: Cleanup routines for feature negotiation"

The function dccp_feat_clean() is removed by this patch (5/14), and the hunk below
can go into the earlier patch without problems (compile-tested the exchange).
|  
|  > --- a/net/dccp/proto.c
|  > +++ b/net/dccp/proto.c
|  > @@ -234,7 +234,6 @@ int dccp_destroy_sock(struct sock *sk)
|  >         dp->dccps_hc_rx_ccid = dp->dccps_hc_tx_ccid = NULL;
|  >
|  >         /* clean up feature negotiation state */
|  > -       dccp_feat_clean(dmsk);
|  >         dccp_feat_list_purge(&dp->dccps_featneg);
|  >
|  >         return 0;
|  > -
|  

      parent reply	other threads:[~2007-10-04 13:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-03 14:02 [PATCH 5/14]: Clean up remains from old feature-negotiation infrastructure Gerrit Renker
2007-10-03 20:00 ` Ian McDonald
2007-10-04 13:08 ` Gerrit Renker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710041408.37460@strip-the-willow \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox