From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 11/25] Share TFRC sender states via tfrc_ccids
Date: Thu, 08 Nov 2007 10:21:44 +0000 [thread overview]
Message-ID: <20071108102144.GC11792@gerrit.erg.abdn.ac.uk> (raw)
In-Reply-To: <200710312131.03012.leandroal@gmail.com>
| @@ -76,16 +76,16 @@ static const char *ccid4_tx_state_name(e
| #endif
|
| static void ccid4_hc_tx_set_state(struct sock *sk,
| - enum ccid4_hc_tx_states state)
| + enum tfrc_hc_tx_states state)
| {
| struct ccid4_hc_tx_sock *hctx = ccid4_hc_tx_sk(sk);
| - enum ccid4_hc_tx_states oldstate = hctx->ccid4hctx_state;
| + enum tfrc_hc_tx_states oldstate = hctx->tfrchctx_state;
|
| ccid4_pr_debug("%s(%p) %-8.8s -> %s\n",
| dccp_role(sk), sk, ccid4_tx_state_name(oldstate),
| ccid4_tx_state_name(state));
| WARN_ON(state = oldstate);
| - hctx->ccid4hctx_state = state;
| + hctx->tfrchctx_state = state;
| }
|
I think this function is a candidate for sharing: no need to keep
this function separate for CCID3/4 when both use the same enum of
states; i.e. the function could be written tfrc_hc_tx_set_state().
next prev parent reply other threads:[~2007-11-08 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 0:31 [PATCH 11/25] Share TFRC sender states via tfrc_ccids Leandro
2007-11-01 12:27 ` Tommi Saviranta
2007-11-04 17:39 ` Ian McDonald
2007-11-04 17:39 ` Ian McDonald
2007-11-08 10:21 ` Gerrit Renker [this message]
2007-11-13 16:33 ` Łeandro Sales
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071108102144.GC11792@gerrit.erg.abdn.ac.uk \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox