DCCP protocol discussions
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: [Announce]: Test Tree and CCID4 Tree updated
Date: Sat, 10 Nov 2007 12:23:20 +0000	[thread overview]
Message-ID: <20071110122320.GA12971@gerrit.erg.abdn.ac.uk> (raw)

This is to announce that the test tree on git://eden-feed.erg.abdn.ac.uk/dccp_exp
has now been updated with regard to removal of spinlocks (changelog as per previous mail).

The CCID4 tree has also been updated to match the changes, changes are below.

----------------------------------------------------------------------------------------
                      CCID 4  Update
----------------------------------------------------------------------------------------
I have patched your second patch [2/25] with regard to the code at the 
bottom of the message and traced those two hunks throughout the patch set. 

The set compiles cleanly (but see other email regarding state names).
I have further `repaired' all the whitespace errors: almost half of the
patches had blanks instead of tabs for indentation. Please check next
time - it is easy to avoid but tedious to get out once it is in.

Can you please check the CCID4 tree out 

	git pull git://eden-feed.erg.abdn.ac.uk/dccp_exp ccid4

and see if you are ok with the state of your patches. Ian has a nice script
to convert a tree into a set of patches, which can be used for this purpose:
	http://wlug.org.nz/KernelDevelopmentWithGit

Note - I have only done compilation tests, it would be good if you run your tests.
Will also do some more CCID4-specific testing when I get a little more time.

Gerrit

---------------> Difference to Patch 2/25 before/after <---------------------

--- a/net/dccp/ccids/ccid4.c
+++ b/net/dccp/ccids/ccid4.c
@@ -781,8 +781,6 @@ static void ccid4_hc_rx_packet_recv(stru
 	u32 sample, payload_size = skb->len - dccp_hdr(skb)->dccph_doff * 4;
 	u8  is_data_packet = dccp_data_packet(skb);
 
-	spin_lock(&hcrx->ccid4hcrx_hist.lock);
-
 	if (unlikely(hcrx->ccid4hcrx_state = TFRC_RSTATE_NO_DATA)) {
 		if (is_data_packet) {
 			do_feedback = FBACK_INITIAL;
@@ -846,8 +844,6 @@ update_records:
 	tfrc_rx_hist_update(&hcrx->ccid4hcrx_hist, skb, ndp);
 
 done_receiving:
-	spin_unlock(&hcrx->ccid4hcrx_hist.lock);
-
 	if (do_feedback)
 		ccid4_hc_rx_send_feedback(sk, skb, do_feedback);
 }

             reply	other threads:[~2007-11-10 12:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-10 12:23 Gerrit Renker [this message]
2007-11-13 16:49 ` [Announce]: Test Tree and CCID4 Tree updated Łeandro Sales

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071110122320.GA12971@gerrit.erg.abdn.ac.uk \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox