From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 09/37] dccp: Resolve dependencies of features on choice
Date: Thu, 04 Sep 2008 00:59:31 +0000 [thread overview]
Message-ID: <20080904005931.GG12639@ghostprotocols.net> (raw)
In-Reply-To: <1219945512-7723-10-git-send-email-gerrit@erg.abdn.ac.uk>
Em Wed, Sep 03, 2008 at 06:51:52AM +0200, Gerrit Renker escreveu:
> | > This provides a missing link in the code chain, as several features implicitly
> | > depend and/or rely on the choice of CCID. Most notably, this is the Send Ack Vector
> | > feature, but also Ack Ratio and Send Loss Event Rate (also taken care of).
> | >
> <snip>
> |
> | Doesn't this belongs into struct ccid_operations? Why has the core feature
> | negotiation have knowledge of any specific CCID? When people want to
> | merge CCID 4, 5, etc will we need to change net/dccp/feat.c?
> |
> | I think that this needs thus to go to struct ccid_operations, and then the feature
> | negotiation code can just use use the ccid number to access:
> |
> | struct ccid_operations *ccids[CCID_MAX]
> |
> | ccids[ccid_number]->deps
> In principle I agree with you, what I am asking for is to defer this code
> optimisation until later.
Fair enough.
- Arnaldo
prev parent reply other threads:[~2008-09-04 0:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 17:44 [PATCH 09/37] dccp: Resolve dependencies of features on choice of CCID Gerrit Renker
2008-08-28 21:07 ` [PATCH 09/37] dccp: Resolve dependencies of features on choice Arnaldo Carvalho de Melo
2008-08-29 6:34 ` Gerrit Renker
2008-09-03 4:51 ` Gerrit Renker
2008-09-04 0:59 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080904005931.GG12639@ghostprotocols.net \
--to=acme@redhat.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox