From: Christoph Hellwig <hch@lst.de>
To: dccp@vger.kernel.org
Subject: Re: get rid of the address_space override in setsockopt v2
Date: Sun, 26 Jul 2020 07:03:11 +0000 [thread overview]
Message-ID: <20200726070311.GA16687@lst.de> (raw)
In-Reply-To: <20200720124737.118617-1-hch@lst.de>
On Fri, Jul 24, 2020 at 03:43:42PM -0700, David Miller wrote:
> > Changes since v1:
> > - check that users don't pass in kernel addresses
> > - more bpfilter cleanups
> > - cosmetic mptcp tweak
>
> Series applied to net-next, I'm build testing and will push this out when
> that is done.
The buildbot found one warning with the isdn debug code after a few
days, here is what I think is the best fix:
---
From 6601732f7a54db5f04efba08f7e9224e5b757112 Mon Sep 17 00:00:00 2001
From: Christoph Hellwig <hch@lst.de>
Date: Sun, 26 Jul 2020 09:00:09 +0200
Subject: mISDN: remove a debug printk in data_sock_setsockopt
The %p won't work with the new sockptr_t type. But in the times of
ftrace, bpftrace and co these kinds of debug printks are pretty anyway,
so just remove the whole debug printk.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/isdn/mISDN/socket.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c
index 1b2b91479107bc..2c58a6fe6d129e 100644
--- a/drivers/isdn/mISDN/socket.c
+++ b/drivers/isdn/mISDN/socket.c
@@ -406,10 +406,6 @@ static int data_sock_setsockopt(struct socket *sock, int level, int optname,
struct sock *sk = sock->sk;
int err = 0, opt = 0;
- if (*debug & DEBUG_SOCKET)
- printk(KERN_DEBUG "%s(%p, %d, %x, %p, %d)\n", __func__, sock,
- level, optname, optval, len);
-
lock_sock(sk);
switch (optname) {
--
2.27.0
next prev parent reply other threads:[~2020-07-26 7:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 12:47 get rid of the address_space override in setsockopt Christoph Hellwig
2020-07-20 16:38 ` Eric Biggers
2020-07-20 17:43 ` Christoph Hellwig
2020-07-20 20:47 ` Alexei Starovoitov
2020-07-21 9:38 ` David Laight
2020-07-21 10:26 ` David Laight
2020-07-22 7:56 ` Christoph Hellwig
2020-07-22 8:06 ` 'Christoph Hellwig'
2020-07-22 8:07 ` 'Christoph Hellwig'
2020-07-22 8:21 ` David Laight
2020-07-22 17:09 ` Alexei Starovoitov
2020-07-23 6:08 ` get rid of the address_space override in setsockopt v2 Christoph Hellwig
2020-07-24 22:43 ` David Miller
2020-07-26 7:03 ` Christoph Hellwig [this message]
2020-07-26 7:08 ` Andreas Schwab
2020-07-26 7:46 ` David Miller
2020-07-27 9:51 ` David Laight
2020-07-27 13:48 ` Al Viro
2020-07-27 14:09 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726070311.GA16687@lst.de \
--to=hch@lst.de \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox