From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Date: Thu, 10 Sep 2020 06:28:12 +0000 Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break; Message-Id: <20200910082812.057a04e6@coco.lan> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dccp@vger.kernel.org Em Wed, 09 Sep 2020 13:06:39 -0700 Joe Perches escreveu: > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block is break; > > Found using: > > $ grep-2.5.4 -rP --include=*.[ch] -n "fallthrough;(\s*(case\s+\w+|default)\s*:\s*){1,7}break;" * > > Miscellanea: > > o Move or coalesce a couple label blocks above a default: block. > > Signed-off-by: Joe Perches > --- > > Compiled allyesconfig x86-64 only. > A few files for other arches were not compiled. > > drivers/media/dvb-frontends/drxd_hard.c | 2 +- > drivers/media/i2c/ov5640.c | 2 +- > drivers/media/i2c/ov6650.c | 5 ++--- > drivers/media/i2c/smiapp/smiapp-core.c | 2 +- > drivers/media/i2c/tvp5150.c | 2 +- > drivers/media/pci/ddbridge/ddbridge-core.c | 2 +- > drivers/media/usb/cpia2/cpia2_core.c | 2 +- For media drivers: Reviewed-by: Mauro Carvalho Chehab Thanks, Mauro