From: Joel Granados <j.granados@samsung.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 06/11] sysctl: Add size to register_net_sysctl function
Date: Wed, 21 Jun 2023 11:49:27 +0000 [thread overview]
Message-ID: <20230621114927.woeidgxx5jhtchxt@localhost> (raw)
In-Reply-To: <20230621091000.424843-7-j.granados@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
On Wed, Jun 21, 2023 at 01:49:54PM +0300, Dan Carpenter wrote:
> On Wed, Jun 21, 2023 at 12:47:30PM +0300, Dan Carpenter wrote:
> > The patchset doesn't include the actual interesting changes, just a
> > bunch of mechanical prep work.
> >
>
> I was wrong here, the patchset just hadn't all hit the mailing lists.
not even. It was that the patch got mangled by some error on my side.
> I can't apply this patchset to anything. I tried linux-next, net, and
> net-next. So it's hard to review.
All this applies cleanly to mcgrof's sysctl-next branch here
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next
>
> It looks like ensure_safe_net_sysctl() never got update to use
> table_size...
Done. I realized this while checking out your other comments. thx.
>
> You could easily write a static checker test to print a warning any time
> that ->procname is checked for NULL. I have attached a Smatch check.
> You would need to added to check_list.h and recompile.
Awesome!!!, I had been doing this with coccinelle, I'll recompile with
smatch and see if I get extra hits. Thx!
>
> net/sysctl_net.c:130 ensure_safe_net_sysctl() warn: checking ->procname 'ent->procname'
Done. Will be available in V2
>
> regards,
> dan carpenter
>
Best
--
Joel Granados
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-06-21 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 9:09 [PATCH 06/11] sysctl: Add size to register_net_sysctl function Joel Granados
2023-06-21 9:47 ` Dan Carpenter
2023-06-21 10:23 ` Dan Carpenter
2023-06-21 10:49 ` Dan Carpenter
2023-06-21 11:36 ` Joel Granados
2023-06-21 11:49 ` Joel Granados [this message]
2023-06-21 12:03 ` Joel Granados
2023-06-23 14:21 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621114927.woeidgxx5jhtchxt@localhost \
--to=j.granados@samsung.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox