From: Patrick McHardy <kaber@trash.net>
To: dccp@vger.kernel.org
Subject: Re: [DCCP]: Fix skb->cb conflicts with IP
Date: Fri, 04 Apr 2008 13:40:55 +0000 [thread overview]
Message-ID: <47F62FE7.9060508@trash.net> (raw)
In-Reply-To: <47F61B5C.8090105@trash.net>
Gerrit Renker wrote:
> Arnaldo,
>
> just a thought - I recall that there used to be a bug related to this,
> which required to insert the following before sending an skb:
>
> memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt))
>
> This was about 1+1/2 .. 2 years ago and lead to crashes when the memset
> was removed. Maybe with this solution the memsets are then no longer
> necessary? The reference is
> * output.c:dccp_transmit_skb()
> * ipv4.c:dccp_v4_send_response()
Yes, that shouldn't be needed anymore with this patch.
next prev parent reply other threads:[~2008-04-04 13:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 12:13 [DCCP]: Fix skb->cb conflicts with IP Patrick McHardy
2008-04-04 13:25 ` Gerrit Renker
2008-04-04 13:26 ` Arnaldo Carvalho de Melo
2008-04-04 13:40 ` Patrick McHardy [this message]
2008-04-04 13:47 ` Arnaldo Carvalho de Melo
2008-04-11 13:41 ` Patrick McHardy
2008-04-11 13:59 ` Gerrit Renker
2008-04-11 14:03 ` Patrick McHardy
2008-04-11 14:05 ` Arnaldo Carvalho de Melo
2008-04-11 18:24 ` David Miller
2008-04-13 1:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F62FE7.9060508@trash.net \
--to=kaber@trash.net \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox