From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: dccp@vger.kernel.org
Subject: [PATCH - test-tree] DCCP: Increment sequence number on retransmitted
Date: Wed, 04 Jun 2008 07:37:19 +0000 [thread overview]
Message-ID: <4846462F.3020004@cn.fujitsu.com> (raw)
When retransmit the first REQUEST, the sequence number does not be
increased. This is because before retransmit the first REQUEST packet,
the icsk->icsk_retransmits is 0, so dccp_transmit_skb() will fetch the
dp->dccps_iss as the retransmit sequence number.
This patch fix the problem.
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
--- a/net/dccp/output.c 2008-05-29 22:27:55.000000000 -0400
+++ b/net/dccp/output.c 2008-05-30 19:26:43.000000000 -0400
@@ -69,9 +69,6 @@ static int dccp_transmit_skb(struct sock
case DCCP_PKT_REQUEST:
set_ack = 0;
- /* Use ISS on the first (non-retransmitted) Request. */
- if (icsk->icsk_retransmits = 0)
- dcb->dccpd_seq = dp->dccps_iss;
/* fall through */
case DCCP_PKT_SYNC:
@@ -526,6 +523,8 @@ int dccp_connect(struct sock *sk)
/* Initialise GAR as per 8.5; AWL/AWH are set in dccp_transmit_skb() */
dp->dccps_gar = dp->dccps_iss;
+ /* Initialise GSS to ISS - 1, will be increased in dccp_transmit_skb() */
+ dp->dccps_gss = SUB48(dp->dccps_iss, 1);
skb = alloc_skb(sk->sk_prot->max_header, sk->sk_allocation);
if (unlikely(skb = NULL))
next reply other threads:[~2008-06-04 7:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 7:37 Wei Yongjun [this message]
2008-06-04 8:09 ` [PATCH - test-tree] DCCP: Increment sequence number on Gerrit Renker
2008-06-04 13:21 ` Arnaldo Carvalho de Melo
2008-06-04 13:38 ` Gerrit Renker
2008-06-04 15:44 ` Arnaldo Carvalho de Melo
2008-06-04 15:55 ` Gerrit Renker
2008-06-04 16:54 ` Arnaldo Carvalho de Melo
2008-06-05 6:51 ` Gerrit Renker
2008-06-05 7:33 ` Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4846462F.3020004@cn.fujitsu.com \
--to=yjwei@cn.fujitsu.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox