From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1E8F156C4D for ; Sat, 24 Aug 2024 12:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724501231; cv=none; b=MJPhsmo9fETqTDPO8+YDdWzbILATQo7ciQLURWfnC25rSXvNlzGTlVgYe7QvPvf11kIeYpL+AV2SO3rhFBOfF+TZMkaw9bIaCZ+sWFLgWd2f/Kv0A0nASPsHsq8QAFtqBWjLv337eBU7nuW+kv+R5Dx4NnuKICX8ash96p7Ki+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724501231; c=relaxed/simple; bh=wh2+8yuwCwCztdr8QUKx7gWE0HfjkgMuVTK/8Ktjyq0=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=QpAXJZmdumYzRiuRuau0k+GihAki6ZUMJ0z22VT6recauw52GBxm4Ls9HOECIw731LQq1d5GpzC3OZ/hHnmqfqmY+i1K2Cuu1aEt8wx6HP0Mt3izdhRFwZ9DRYD3M+Pu8AWkALMBVYMHj62sqj3GcQKcSS8MR8ogQ6Qa6u4+x6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OnqNjRX0; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OnqNjRX0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724501228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a1bEMmhYWPcc5WPaVCBGyBfQe+5Fop9dOF/SHjPvxFk=; b=OnqNjRX0t57oj+jH4YnemWcy2PaRGlkKBSxZlJ0FNQ5E3qUD0V6l0/0AQbrQ56FX5+Ljxf Ed/jsWPu16TM1gL9WwaIYIe2ITzPMytrKdjgsXxiOWKzm8besR4JYTU0105AoUlhpqGqmm J2N4K/q4ypZ40a8ahsben6CCdzP+xis= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-301-nFmxqG7ZOOixq3NNP-L_GQ-1; Sat, 24 Aug 2024 08:07:04 -0400 X-MC-Unique: nFmxqG7ZOOixq3NNP-L_GQ-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B28721955D47; Sat, 24 Aug 2024 12:07:01 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.30]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DF8BA3001FF9; Sat, 24 Aug 2024 12:06:56 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240824074033.2134514-8-lihongbo22@huawei.com> References: <20240824074033.2134514-8-lihongbo22@huawei.com> <20240824074033.2134514-1-lihongbo22@huawei.com> To: Hongbo Li Cc: dhowells@redhat.com, johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, allison.henderson@oracle.com, dsahern@kernel.org, pshelar@ovn.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, dccp@vger.kernel.org, dev@openvswitch.org, linux-afs@lists.infradead.org Subject: Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code Precedence: bulk X-Mailing-List: dccp@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <563922.1724501215.1@warthog.procyon.org.uk> Date: Sat, 24 Aug 2024 13:06:55 +0100 Message-ID: <563923.1724501215@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Hongbo Li wrote: > - summary.ack_reason = (sp->ack.reason < RXRPC_ACK__INVALID ? > - sp->ack.reason : RXRPC_ACK__INVALID); > + summary.ack_reason = min(sp->ack.reason, RXRPC_ACK__INVALID); Can you use umin() rather than min(), please? Thanks, David