From: David Ahern <dsahern@kernel.org>
To: dccp@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/4] net: wire up support for file_operations->uring_cmd()
Date: Mon, 19 Jun 2023 16:12:55 +0000 [thread overview]
Message-ID: <f9a85fcc-33e3-b47b-9c32-1d680edadcf8@kernel.org> (raw)
In-Reply-To: <20230614110757.3689731-2-leitao@debian.org>
On 6/19/23 4:20 AM, Breno Leitao wrote:
> On Wed, Jun 14, 2023 at 08:15:10AM -0700, David Ahern wrote:
>> On 6/14/23 5:07 AM, Breno Leitao wrote:
>> io_uring is just another in-kernel user of sockets. There is no reason
>> for io_uring references to be in core net code. It should be using
>> exposed in-kernel APIs and doing any translation of its op codes in
>> io_uring/ code.
> Thanks for the feedback. If we want to keep the network subsystem
> untouched, then I we can do it using an approach similar to the
> following. Is this a better approach moving forward?
yes. It keeps the translation from io_uring commands to networking APIs
in one place and does not need to propagate that translation through the
networking code.
next prev parent reply other threads:[~2023-06-19 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 11:07 [RFC PATCH v2 1/4] net: wire up support for file_operations->uring_cmd() Breno Leitao
2023-06-14 15:15 ` David Ahern
2023-06-19 9:28 ` Pavel Begunkov
2023-06-19 11:20 ` Breno Leitao
2023-06-19 14:18 ` Kanchan Joshi
2023-06-19 16:12 ` David Ahern [this message]
2023-06-20 2:09 ` David Ahern
2023-06-23 10:17 ` Stefan Metzmacher
2023-06-23 15:20 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9a85fcc-33e3-b47b-9c32-1d680edadcf8@kernel.org \
--to=dsahern@kernel.org \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox