From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [RFC 3/3] checks: Add unit-address checks for PCI buses
Date: Wed, 23 Mar 2016 19:40:21 -0500 [thread overview]
Message-ID: <1458780021-5052-3-git-send-email-robh@kernel.org> (raw)
In-Reply-To: <1458780021-5052-1-git-send-email-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
PCI device unit addresses are in the form DD or DD,F where DD is the
device 0-0x1f and F is the function 0-7. Add checks that the unit
address matches this form.
Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
checks.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/checks.c b/checks.c
index 82a7f38..1d0fcfb 100644
--- a/checks.c
+++ b/checks.c
@@ -549,10 +549,30 @@ static bool is_pci_bridge(struct node *node)
return false;
}
+static void pci_unit_addr(struct check *c, struct node *dt, struct node *node)
+{
+ const char *unitname = get_unitname(node);
+ unsigned int dev, func;
+ int ret;
+
+ ret = sscanf(unitname, "%2x,%1x", &dev, &func);
+ if (ret >= 1) {
+ if (dev > 0x1f)
+ FAIL(c, "Node %s PCI device number out of range",
+ node->fullpath);
+ }
+ if (ret == 2) {
+ if (func > 7)
+ FAIL(c, "Node %s PCI function number out of range",
+ node->fullpath);
+ }
+}
+
struct bus_type pci_bus_type = {
.expected_addr_cells = 3,
.expected_size_cells = 2,
.is_type = is_pci_bridge,
+ .check_unit_addr = pci_unit_addr,
};
static bool is_simple_bridge(struct node *node)
--
2.5.0
next prev parent reply other threads:[~2016-03-24 0:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 0:40 [RFC 1/3] checks: Add infrastructure for setting bus type of nodes Rob Herring
[not found] ` <1458780021-5052-1-git-send-email-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-03-24 0:40 ` [RFC 2/3] checks: Add unit-address checks for simple-bus and default Rob Herring
[not found] ` <1458780021-5052-2-git-send-email-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-03-31 5:29 ` David Gibson
[not found] ` <20160331052912.GE416-1s0os16eZneny3qCrzbmXA@public.gmane.org>
2016-03-31 16:18 ` Rob Herring
[not found] ` <CAL_JsqJO+9Wna4mjeRLj+ELy7BwL7K=QEVrNGs3CuAaE3Y_Q3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-01 2:27 ` David Gibson
[not found] ` <20160401022735.GJ416-1s0os16eZneny3qCrzbmXA@public.gmane.org>
2016-04-01 18:50 ` Rob Herring
[not found] ` <CAL_JsqLup+esWdQ1dzpOaj17BaE2d2CJ6sJAqBUcNx2xBvNFKg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-04 0:22 ` David Gibson
2016-03-24 0:40 ` Rob Herring [this message]
[not found] ` <1458780021-5052-3-git-send-email-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-03-31 5:32 ` [RFC 3/3] checks: Add unit-address checks for PCI buses David Gibson
[not found] ` <20160331053220.GF416-1s0os16eZneny3qCrzbmXA@public.gmane.org>
2016-04-01 19:52 ` Rob Herring
[not found] ` <CAL_JsqK5Ze4P8ofykfebV30TrMzur0cvhZi_RQMkW-kUbsvTpw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-04 1:08 ` David Gibson
2016-03-31 5:22 ` [RFC 1/3] checks: Add infrastructure for setting bus type of nodes David Gibson
[not found] ` <20160331052247.GD416-1s0os16eZneny3qCrzbmXA@public.gmane.org>
2016-03-31 15:17 ` Rob Herring
[not found] ` <CAL_JsqKTarcy2UHKD5m2F7TNP3stNnpCdxTrptGeiTXJJHiGaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-01 2:23 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458780021-5052-3-git-send-email-robh@kernel.org \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).