devicetree-compiler.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Frank Rowand
	<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Lots of "Warning (unit_address_vs_reg): Node /blah/blah/blah has a unit name, but no reg property"
Date: Tue, 31 Jan 2017 08:28:28 +0000	[thread overview]
Message-ID: <1485851308.7612.34.camel@hellion.org.uk> (raw)
In-Reply-To: <CAL_JsqLzW=XUNmzscL6GXMrP_TinPtcpuzatwz-gkC8X9BUQUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Mon, 2017-01-30 at 10:46 -0600, Rob Herring wrote:
> +dtc list
> 
> On Mon, Jan 30, 2017 at 3:55 AM, Ian Campbell <ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
> wrote:
> > I recently updated the device-tree-compiler package on the system
> which
> > builds the split device tree repo[0] from 1.4.0+dfsg-2 to 1.4.2-1
> > (debian package versions) and now during the test build I see many
> > (over 1,000) of these:
> >
> >     Warning (unit_address_vs_reg): Node /soc@ff700000/ethernet@b000
> 0 has a unit name, but no reg property
> >
> > Is this something which is known? Maybe Linux hasn't pulled in the
> > newer dtc yet so you aren't hitting it yet, or maybe you've done
> what I
> > did as a quick fix and added:
> >     DTC_FLAGS="-W no-unit_address_vs_reg"
> > ?
> 
> Linux has this, but the warnings are only enabled with "W=1" builds.
> I'm trying to not have to review the trivial crap.

Specifically Linux adds the DTC_FLAGS="-W no-unit_address_vs_reg" only
if W=0 (rather than enabling it if W=1).

I'll disable that one in the split tree too then.

> It's going to spew even more soon. I've posted some more dtc checks
> last week.

Fun!

> > (a second issue is the lack of the offending filename in the
> > warning message, I'll figure out the right venue for that next)
> 
> Yeah, I don't think the dtc checks infrastructure has the information
> as they run on the live tree after all the parsing is done.

I also started a thread on -compiler. I've replied there already (to
whit: printing the output filename in the warning would be a useful
improvement).

Ian.

      parent reply	other threads:[~2017-01-31  8:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1485770101.2451.40.camel@hellion.org.uk>
     [not found] ` <1485770101.2451.40.camel-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
2017-01-30 16:46   ` Lots of "Warning (unit_address_vs_reg): Node /blah/blah/blah has a unit name, but no reg property" Rob Herring
     [not found]     ` <CAL_JsqLzW=XUNmzscL6GXMrP_TinPtcpuzatwz-gkC8X9BUQUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-31  8:28       ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485851308.7612.34.camel@hellion.org.uk \
    --to=ijc-kcikpvwj1kudxyznreorvg@public.gmane.org \
    --cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).