Re: [PATCH] libfdt.h: Define FDT_PATH_MAX

[Pantelis Antoniou <pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>]

Hi David,

On Wed, 2017-06-14 at 23:05 +0800, David Gibson wrote:
> On Wed, Jun 14, 2017 at 05:51:48PM +0300, Pantelis Antoniou wrote:
> > Declare the maximum path size of an FDT node.
> > It is useful for manipulation methods that need to know a maximum value.
> > 
> > Signed-off-by: Pantelis Antoniou <pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
> 
> Why do you need this.  I've really tried to avoid adding arbitrary
> size limits on things.
> 

The stacked overlay patch needs it; has to 'read' in a path into a
buffer and manipulate it. Otherwise it I would have to add a new method
that walks the path and returns the size of it so that I can allocate
the exact amount. This seems excessive IMO compared to a hard max limit.

It is similar to the way PATH_MAX works in *nix which makes things
somewhat familiar.

Regards

-- Pantelis

> > ---
> >  libfdt/libfdt.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/libfdt/libfdt.h b/libfdt/libfdt.h
> > index a248b1b..a5c93f6 100644
> > --- a/libfdt/libfdt.h
> > +++ b/libfdt/libfdt.h
> > @@ -139,6 +139,9 @@
> >  
> >  #define FDT_ERR_MAX		17
> >  
> > +/* Maximum path size of a node (similar to PATH_MAX in *nix) */
> > +#define FDT_PATH_MAX	4096
> > +
> >  /**********************************************************************/
> >  /* Low-level functions (you probably don't need these)                */
> >  /**********************************************************************/
>