Re: [RESEND PATCH v3 1/3] libfdt: Add function to find regions in an FDT

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

On Thu, May 01, 2014 at 09:13:51AM -0700, Simon Glass wrote:
> Hi,
> 
> On 22 March 2014 08:07, Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
> > Given a set of nodes and properties, find the regions of the device tree
> > which describe those parts.
> >
> > A test is provided which builds a tree while tracking where the regions
> > should be, then calls fdt_first/next_region() to make sure that it agrees.
> >
> > Further tests will come as part of fdtgrep.
> >
> > Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> 
> Have I sent this to the right place? Any comments?

Sorry.  I know you've resent this several times, and I've been
procrastinating about it since forever.

Basically, I'm just not convinced.  For all your efforts to explain
the rationale, it just seems like a really ad-hoc set of flags and
conditions that doesn't seem to form a coherent whole.

From the lack of other responses, I'm assuming there's not really
anyone else who sees it as a compelling feature either.

So, sorry.  For the forseeable future, you'll need to leave this
implemented in your own code, using but outside of libfdt itself.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]