From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH 2/2] Add embedded nul string list test Date: Thu, 19 Jun 2014 11:57:14 +1000 Message-ID: <20140619015714.GK29264@voom.redhat.com> References: <1402936552-10249-1-git-send-email-jack@codezen.org> <1402936552-10249-3-git-send-email-jack@codezen.org> <20140618012729.GE29264@voom.redhat.com> <20140618173519.GA15740@toadite.austin.ibm.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Z9t8O/5YJLB6LEUl" Return-path: Content-Disposition: inline In-Reply-To: <20140618173519.GA15740-O8SCTCEbm15XsEFxtoW7CMxtgHpCUUYS@public.gmane.org> Sender: devicetree-compiler-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: Jack Miller Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org --Z9t8O/5YJLB6LEUl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 18, 2014 at 12:35:19PM -0500, Jack Miller wrote: > On Wed, Jun 18, 2014 at 11:27:29AM +1000, David Gibson wrote: > > > @@ -310,6 +310,9 @@ dtc_tests () { > > > run_dtc_test -I dts -O dtb -o dtc_comments-cmp.test.dtb comments= -cmp.dts > > > run_test dtbs_equal_ordered dtc_comments.test.dtb dtc_comments-c= mp.test.dtb > > > =20 > > > + run_dtc_test -I dts -O dtb -o dtc_nul_string_list.dtb nul_string= _list.dts > >=20 > > dtb files generated by the tests should be named XXX.test.dtb so that > > make clean will clean them up again. >=20 > Hmmm, the greater problem here seems to be that I'm including a .dtb that > *isn't* disposable and will be cleaned. Should this test check that the > generated dtb decompiles into "","","" format instead of comparing to a > binary? That seems a little weak as it assumes that the intermediate .dtb= is > correct, but I don't know your thoughts on including binaries into your t= est > directory. So, I thought about that. It would be possible to avoid by making a comparison .dts which includes the NULs using string escapes or bytestrings instead of NULs in the input, then comparing the .dtb outputs from each. However, I don't think there's a real problem with a pre-built dtb, git handles binary files adequately well. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Z9t8O/5YJLB6LEUl Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJTokN6AAoJEGw4ysog2bOSPqIQAJvxXRubtFiauS6F8jJ2xnmQ fHu6lkg3moaEKgXwxJmmY4YXfI8F2Dl5LcpV9HIGrdDskAF0vCmfA1qbI1cY3QYP YhA/pudhQPzfXqDOvII2F620OdDal9e/SfeeKJfZimjZWRJTeILeOMHwyJk1MVlC 3YzEqOEWYR41BL/CfLjlKE6pc1XF8jM11itOgN9ufeZ+8QoqR17rAuAaxAyQpaK8 2lJjc6FTRdbrhxbN4/RUUyYekjFwK9J7vh5oSeh/FhDqBLTKy27zlZj3qJz1FO98 lACdnLw7GkxbM3DbQVtWzyUnoRkJ/WcntaSB4eZWTMY1A4H2K/pV38kDJ2BQcZe1 2myiWuclxSb+rFR9aQNgTA7BIvvLHl7CJsYzqVcq07+jG5uzbyJP7oCl8gL+iTAW YrrfULCQ6dzlchRadrBTwf1itBmpupFKSGxhKwyA2xqPsJkYaa3CoQCg/nLAoXxE z5+4hm1dNwFTlrLr2TeQN7Iz9viqA1s9x9n/hwiuZhyo7r++aYVa0KJA1/1jYwxU tro533VtxwM6ZBDkw+QPPIi4FtnExChndVXx9opd8oqlKE1ZmB/WK5PvzZpfE5RB ZI4qSDbVTv9ONzZc3KfVDGojNd0ndA1A9H5ZnzamUNLXwwL75ZPipllAXlwJ8ffj 6u2es9SnYZ3z3QIrUvkU =SdJV -----END PGP SIGNATURE----- --Z9t8O/5YJLB6LEUl-- -- To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html