From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Phil Elwell <phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] dtc: Improve portability
Date: Wed, 22 Oct 2014 14:01:06 +0200 [thread overview]
Message-ID: <20141022120106.GG2880@voom> (raw)
In-Reply-To: <54462F50.4080706-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On Tue, Oct 21, 2014 at 11:02:56AM +0100, Phil Elwell wrote:
> 1) Remove the double parentheses around two comparisons in checks.c.
> The OSX LLVM-based C compiler warns about them.
That seems a weird thing to warn for, but the result is cleaner
anyway, so I'm happy to apply it.
> 2) Put an explicit "=" in the TN() macro, in accordance with c99.
I'm slightly astonished that ever worked.
I need a Signed-off-by line, then I can apply.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-22 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 10:02 [PATCH] dtc: Improve portability Phil Elwell
[not found] ` <54462F50.4080706-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2014-10-22 12:01 ` David Gibson [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-23 10:23 Phil Elwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022120106.GG2880@voom \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).