From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Jack Miller <jack-jZyo8ZIaZD9AfugRpC6u6w@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Fix crash with poorly defined #size-cells
Date: Thu, 30 Apr 2015 10:56:48 +1000 [thread overview]
Message-ID: <20150430005648.GA32589@voom.redhat.com> (raw)
In-Reply-To: <1430334144-26986-1-git-send-email-jack-jZyo8ZIaZD9AfugRpC6u6w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
On Wed, Apr 29, 2015 at 02:02:24PM -0500, Jack Miller wrote:
> If you have a parent block with #size-cells improperly set to 0, and
> then subsequently try to include a regs property in the child, dtc will
> crash with SIGFPE while validating it. This patch fixes that crash,
> instead printing the same invalid length warning that was causing it.
>
> Test included.
>
> Signed-off-by: Jack Miller <jack-jZyo8ZIaZD9AfugRpC6u6w@public.gmane.org>
Applied, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-04-30 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 19:02 [PATCH] Fix crash with poorly defined #size-cells Jack Miller
[not found] ` <1430334144-26986-1-git-send-email-jack-jZyo8ZIaZD9AfugRpC6u6w@public.gmane.org>
2015-04-30 0:56 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430005648.GA32589@voom.redhat.com \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jack-jZyo8ZIaZD9AfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).