[PATCH] Remove duplicated -Werror in dtc Makefile

[PATCH] Remove duplicated -Werror in dtc Makefile

[Thomas Huth]

The "-Werror" compiler flag is currently declared twice in the
Makefile, one time in WARNINGS, and one time in CFLAGS. Let's
remove one of them.

Signed-off-by: Thomas Huth <thuth-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index c1d0757..75ab67e 100644
--- a/Makefile
+++ b/Makefile
@@ -18,7 +18,7 @@ CONFIG_LOCALVERSION =
 CPPFLAGS = -I libfdt -I .
 WARNINGS = -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs \
 	-Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wshadow
-CFLAGS = -g -Os -fPIC -Werror $(WARNINGS)
+CFLAGS = -g -Os -fPIC $(WARNINGS)
 
 BISON = bison
 LEX = flex
-- 
1.8.3.1

Re: [PATCH] Remove duplicated -Werror in dtc Makefile

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

On Tue, Nov 03, 2015 at 01:02:00PM +0100, Thomas Huth wrote:
> The "-Werror" compiler flag is currently declared twice in the
> Makefile, one time in WARNINGS, and one time in CFLAGS. Let's
> remove one of them.
> 
> Signed-off-by: Thomas Huth <thuth-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Applied, thanks.  However, I moved the remaining -Werror from WARNINGS
to CFLAGS - the idea is that WARNINGS controls just which warnings are
enabled, wheres -Werror controls what happens when a warning occurs.

> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index c1d0757..75ab67e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -18,7 +18,7 @@ CONFIG_LOCALVERSION =
>  CPPFLAGS = -I libfdt -I .
>  WARNINGS = -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs \
>  	-Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wshadow
> -CFLAGS = -g -Os -fPIC -Werror $(WARNINGS)
> +CFLAGS = -g -Os -fPIC $(WARNINGS)
>  
>  BISON = bison
>  LEX = flex

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]