Re: [PATCH v3 09/12] libfdt: Add fdt_getprop_namelen_w

From: David Gibson <david@gibson.dropbear.id.au>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Tom Rini <trini@konsulko.com>,
	u-boot@lists.denx.de,
	Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
	Alexander Kaplan <alex@nextthing.co>,
	devicetree-compiler@vger.kernel.org
Subject: Re: [PATCH v3 09/12] libfdt: Add fdt_getprop_namelen_w
Date: Mon, 27 Jun 2016 01:49:29 +1000	[thread overview]
Message-ID: <20160626154929.GT15625@voom.fritz.box> (raw)
In-Reply-To: <20160624142757.32735-10-maxime.ripard@free-electrons.com>

[-- Attachment #1.1: Type: text/plain, Size: 1262 bytes --]

On Fri, Jun 24, 2016 at 04:27:54PM +0200, Maxime Ripard wrote:
> Add a function to retrieve a writeable property only by the first
> characters of its name.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  include/libfdt.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/libfdt.h b/include/libfdt.h
> index dbe8a0efca87..b8758de3ae54 100644
> --- a/include/libfdt.h
> +++ b/include/libfdt.h
> @@ -619,6 +619,13 @@ const void *fdt_getprop_by_offset(const void *fdt, int offset,
>   */
>  const void *fdt_getprop_namelen(const void *fdt, int nodeoffset,
>  				const char *name, int namelen, int *lenp);
> +static inline void *fdt_getprop_namelen_w(void *fdt, int nodeoffset,
> +					  const char *name, int namelen,
> +					  int *lenp)
> +{
> +	return (void *)(uintptr_t)fdt_getprop_namelen(fdt, nodeoffset, name,
> +						      namelen, lenp);
> +}

I believe you used this in your new setprop_inpace implementation.  So
the series needs to be re-ordered to avoid breaking bisection.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 134 bytes --]

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot