From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: "Pantelis Antoniou"
<pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>,
"Simon Glass" <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"Boris Brezillon"
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"Alexander Kaplan" <alex-MflLfwwFzuz+yO7R74ARew@public.gmane.org>,
"Thomas Petazzoni"
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Antoine Ténart"
<antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"Hans de Goede"
<hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Tom Rini" <trini-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>,
u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org,
"Stefan Agner" <stefan-XLVq0VzYD2Y@public.gmane.org>
Subject: Re: [PATCH v3 04/12] libfdt: Add new headers and defines
Date: Tue, 28 Jun 2016 13:02:55 +1000 [thread overview]
Message-ID: <20160628030255.GX4242@voom.fritz.box> (raw)
In-Reply-To: <20160627072527.GQ4000@lukather>
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
On Mon, Jun 27, 2016 at 09:25:27AM +0200, Maxime Ripard wrote:
> Hi David,
>
> On Mon, Jun 27, 2016 at 01:39:06AM +1000, David Gibson wrote:
> > On Fri, Jun 24, 2016 at 04:27:49PM +0200, Maxime Ripard wrote:
> > > The libfdt overlay support introduces a bunch of new includes and
> > > functions.
> > >
> > > Make sure we are able to build it by adding the needed glue.
> > >
> > > Signed-off-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> >
> > Is this intended only for downstream u-boot only, or also for upstream
> > libfdt?
>
> U-Boot only.
>
> > If it's u-boot only, you don't really need the #ifdef UBOOT.
>
> Unfortunately, libfdt_env.h is also included by some userspace tools
> in U-Boot, which make use of strtoul while simple_strtoul is not
> defined there (and we should rely on libc's anyway), leading to
> link errors.
Ah, ok. The ifdef makes sense then.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-28 3:02 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 14:27 [PATCH v3 00/12] cmd: fdt: Add device tree overlays support Maxime Ripard
[not found] ` <20160624142757.32735-1-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-24 14:27 ` [PATCH v3 01/12] cmd: fdt: Narrow the check for fdt addr Maxime Ripard
2016-06-24 14:27 ` [PATCH v3 02/12] scripts: Makefile.lib: Sanitize DTB names Maxime Ripard
2016-06-24 14:27 ` [PATCH v3 03/12] vsprintf: Include stdarg for va_list Maxime Ripard
2016-06-24 14:27 ` [PATCH v3 04/12] libfdt: Add new headers and defines Maxime Ripard
[not found] ` <20160624142757.32735-5-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-26 2:53 ` Simon Glass
2016-06-26 15:39 ` David Gibson
[not found] ` <20160626153906.GQ15625-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-06-27 7:25 ` Maxime Ripard
2016-06-28 3:02 ` David Gibson [this message]
2016-06-24 14:27 ` [PATCH v3 05/12] libfdt: Add iterator over properties Maxime Ripard
[not found] ` <20160624142757.32735-6-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-26 2:53 ` Simon Glass
2016-06-24 14:27 ` [PATCH v3 06/12] libfdt: Add max phandle retrieval function Maxime Ripard
[not found] ` <20160624142757.32735-7-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-26 2:53 ` Simon Glass
2016-06-24 14:27 ` [PATCH v3 07/12] libfdt: Add fdt_setprop_inplace_by_index Maxime Ripard
[not found] ` <20160624142757.32735-8-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-26 2:53 ` Simon Glass
[not found] ` <CAPnjgZ2iperwdKGa=+BF8ypH+yRJ8NnP24Fti-PbXDs5bfg3dA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-26 8:09 ` Maxime Ripard
2016-06-26 15:45 ` David Gibson
[not found] ` <20160626154510.GR15625-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-06-27 9:16 ` Maxime Ripard
2016-06-28 3:05 ` David Gibson
2016-06-24 14:27 ` [PATCH v3 08/12] libfdt: Add fdt_path_offset_namelen Maxime Ripard
[not found] ` <20160624142757.32735-9-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-26 2:53 ` Simon Glass
2016-06-26 8:10 ` Maxime Ripard
2016-06-29 3:27 ` Simon Glass
2016-06-26 15:47 ` David Gibson
2016-06-24 14:27 ` [PATCH v3 09/12] libfdt: Add fdt_getprop_namelen_w Maxime Ripard
[not found] ` <20160624142757.32735-10-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-26 2:53 ` Simon Glass
[not found] ` <CAPnjgZ32sm6PHXYHmqrb59XM1NiNeF5+4V-V35hn=YSmLjNMtQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-26 8:11 ` Maxime Ripard
2016-06-26 15:49 ` David Gibson
[not found] ` <20160626154929.GT15625-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-06-27 7:29 ` Maxime Ripard
2016-06-24 14:27 ` [PATCH v3 10/12] libfdt: Add overlay application function Maxime Ripard
[not found] ` <20160624142757.32735-11-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-26 2:53 ` Simon Glass
[not found] ` <CAPnjgZ0dg-CX0XAxCirB-xLO2Jf_Q9T7rc5vu2qznDkYwA54ew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-27 7:13 ` Maxime Ripard
2016-06-27 5:26 ` David Gibson
[not found] ` <20160627052607.GK4242-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-06-27 11:40 ` Maxime Ripard
2016-06-28 3:12 ` David Gibson
[not found] ` <20160628031252.GZ4242-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-06-30 2:34 ` Frank Rowand
2016-06-30 5:08 ` David Gibson
2016-06-24 14:27 ` [PATCH v3 11/12] cmd: fdt: add fdt overlay application subcommand Maxime Ripard
2016-06-24 14:27 ` [PATCH v3 12/12] tests: Introduce DT overlay tests Maxime Ripard
[not found] ` <20160624142757.32735-13-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-27 5:26 ` David Gibson
[not found] ` <20160627052658.GL4242-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-06-27 6:30 ` Maxime Ripard
2016-06-27 6:47 ` David Gibson
2016-06-26 15:37 ` [PATCH v3 00/12] cmd: fdt: Add device tree overlays support David Gibson
[not found] ` <20160626153719.GP15625-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-06-27 6:29 ` Maxime Ripard
2016-06-29 3:28 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628030255.GX4242@voom.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=alex-MflLfwwFzuz+yO7R74ARew@public.gmane.org \
--cc=antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=trini-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).