From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: "Pantelis Antoniou"
<pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>,
"Simon Glass" <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"Boris Brezillon"
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"Alexander Kaplan" <alex-MflLfwwFzuz+yO7R74ARew@public.gmane.org>,
"Thomas Petazzoni"
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Antoine Ténart"
<antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"Hans de Goede"
<hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Tom Rini" <trini-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>,
u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org,
"Stefan Agner" <stefan-XLVq0VzYD2Y@public.gmane.org>
Subject: Re: [PATCH v4 07/13] libfdt: Fix separator spelling
Date: Wed, 6 Jul 2016 11:16:41 +1000 [thread overview]
Message-ID: <20160706011641.GQ2251@voom.fritz.box> (raw)
In-Reply-To: <20160705082646.25044-8-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]
On Tue, Jul 05, 2016 at 10:26:40AM +0200, Maxime Ripard wrote:
> The function fdt_path_next_seperator had an obvious mispell. Fix it.
>
> Signed-off-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Huh.. this entire function appears not to be in upstream libfdt.
> ---
> lib/libfdt/fdt_ro.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/libfdt/fdt_ro.c b/lib/libfdt/fdt_ro.c
> index 503150ef1dc5..6b737b211d2e 100644
> --- a/lib/libfdt/fdt_ro.c
> +++ b/lib/libfdt/fdt_ro.c
> @@ -140,12 +140,12 @@ int fdt_subnode_offset(const void *fdt, int parentoffset,
> }
>
> /*
> - * Find the next of path seperator, note we need to search for both '/' and ':'
> + * Find the next of path separator, note we need to search for both '/' and ':'
> * and then take the first one so that we do the right thing for e.g.
> * "foo/bar:option" and "bar:option/otheroption", both of which happen, so
> * first searching for either ':' or '/' does not work.
> */
> -static const char *fdt_path_next_seperator(const char *path)
> +static const char *fdt_path_next_separator(const char *path)
> {
> const char *sep1 = strchr(path, '/');
> const char *sep2 = strchr(path, ':');
> @@ -168,7 +168,7 @@ int fdt_path_offset(const void *fdt, const char *path)
>
> /* see if we have an alias */
> if (*path != '/') {
> - const char *q = fdt_path_next_seperator(path);
> + const char *q = fdt_path_next_separator(path);
>
> if (!q)
> q = end;
> @@ -188,7 +188,7 @@ int fdt_path_offset(const void *fdt, const char *path)
> p++;
> if (*p == '\0' || *p == ':')
> return offset;
> - q = fdt_path_next_seperator(p);
> + q = fdt_path_next_separator(p);
> if (!q)
> q = end;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-06 1:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 8:26 [PATCH v4 00/13] cmd: fdt: Add device tree overlays support Maxime Ripard
[not found] ` <20160705082646.25044-1-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-07-05 8:26 ` [PATCH v4 01/13] cmd: fdt: Narrow the check for fdt addr Maxime Ripard
[not found] ` <20160705082646.25044-2-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-08-16 1:52 ` [U-Boot,v4,01/13] " Jaehoon Chung
[not found] ` <cf8fe411-8503-78d3-1603-05f1bacd0eb1-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-08-16 1:55 ` Tom Rini
2016-08-17 2:31 ` Jaehoon Chung
[not found] ` <3d40964a-47ce-c9cf-302a-c5f960245928-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-08-17 12:48 ` Tom Rini
2016-08-21 15:06 ` Tom Rini
2016-07-05 8:26 ` [PATCH v4 02/13] scripts: Makefile.lib: Sanitize DTB names Maxime Ripard
[not found] ` <20160705082646.25044-3-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-08-21 15:06 ` [U-Boot,v4,02/13] " Tom Rini
2016-07-05 8:26 ` [PATCH v4 03/13] vsprintf: Include stdarg for va_list Maxime Ripard
[not found] ` <20160705082646.25044-4-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-08-21 15:06 ` [U-Boot,v4,03/13] " Tom Rini
2016-07-05 8:26 ` [PATCH v4 04/13] libfdt: Add new headers and defines Maxime Ripard
[not found] ` <20160705082646.25044-5-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-08-21 15:07 ` [U-Boot,v4,04/13] " Tom Rini
2016-07-05 8:26 ` [PATCH v4 05/13] libfdt: Add iterator over properties Maxime Ripard
[not found] ` <20160705082646.25044-6-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-08-21 15:07 ` [U-Boot,v4,05/13] " Tom Rini
2016-07-05 8:26 ` [PATCH v4 06/13] libfdt: Add max phandle retrieval function Maxime Ripard
[not found] ` <20160705082646.25044-7-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-07-06 1:13 ` David Gibson
2016-08-21 15:07 ` [U-Boot,v4,06/13] " Tom Rini
2016-07-05 8:26 ` [PATCH v4 07/13] libfdt: Fix separator spelling Maxime Ripard
[not found] ` <20160705082646.25044-8-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-07-06 1:16 ` David Gibson [this message]
[not found] ` <20160706011641.GQ2251-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-07-11 6:59 ` Maxime Ripard
2016-08-21 15:07 ` [U-Boot,v4,07/13] " Tom Rini
2016-07-05 8:26 ` [PATCH v4 08/13] libfdt: Add fdt_path_offset_namelen Maxime Ripard
[not found] ` <20160705082646.25044-9-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-07-06 1:21 ` David Gibson
2016-08-21 15:07 ` [U-Boot,v4,08/13] " Tom Rini
2016-07-05 8:26 ` [PATCH v4 09/13] libfdt: Add fdt_getprop_namelen_w Maxime Ripard
[not found] ` <20160705082646.25044-10-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-07-06 1:22 ` David Gibson
2016-07-11 7:12 ` Maxime Ripard
2016-07-12 5:10 ` David Gibson
2016-08-21 15:07 ` [U-Boot,v4,09/13] " Tom Rini
2016-07-05 8:26 ` [PATCH v4 10/13] libfdt: Add fdt_setprop_inplace_namelen_partial Maxime Ripard
[not found] ` <20160705082646.25044-11-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-08-21 15:07 ` [U-Boot,v4,10/13] " Tom Rini
2016-07-05 8:26 ` [PATCH v4 11/13] libfdt: Add overlay application function Maxime Ripard
[not found] ` <20160705082646.25044-12-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-08-21 15:07 ` [U-Boot,v4,11/13] " Tom Rini
2016-07-05 8:26 ` [PATCH v4 12/13] cmd: fdt: add fdt overlay application subcommand Maxime Ripard
[not found] ` <20160705082646.25044-13-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-08-21 15:08 ` [U-Boot,v4,12/13] " Tom Rini
2016-07-05 8:26 ` [PATCH v4 13/13] tests: Introduce DT overlay tests Maxime Ripard
[not found] ` <20160705082646.25044-14-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-08-21 15:08 ` [U-Boot,v4,13/13] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706011641.GQ2251@voom.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=alex-MflLfwwFzuz+yO7R74ARew@public.gmane.org \
--cc=antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=trini-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).