From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v5 5/8] libfdt: Add fdt_setprop_inplace_namelen_partial Date: Fri, 23 Sep 2016 15:02:17 +0300 Message-ID: <20160923120217.GR8719@lukather> References: <20160729095551.13592-1-maxime.ripard@free-electrons.com> <20160729095551.13592-6-maxime.ripard@free-electrons.com> <20160801033642.GV2588@voom.fritz.box> <20160822100721.GI7104@lukather> <20160822130156.GA20266@littlecatz> <20160922063922.GJ8719@lukather> <20160923053120.GY2085@umbus.fritz.box> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="M2XkPJ45YXpBrBm3" Return-path: Content-Disposition: inline In-Reply-To: <20160923053120.GY2085-K0bRW+63XPQe6aEkudXLsA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: David Gibson Cc: Pantelis Antoniou , Simon Glass , Boris Brezillon , Alexander Kaplan , Thomas Petazzoni , devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Antoine =?iso-8859-1?Q?T=E9nart?= , Stefan Agner , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org --M2XkPJ45YXpBrBm3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi David, On Fri, Sep 23, 2016 at 03:31:20PM +1000, David Gibson wrote: > On Thu, Sep 22, 2016 at 09:39:22AM +0300, Maxime Ripard wrote: > > Hi David, > >=20 > > On Mon, Aug 22, 2016 at 09:01:56AM -0400, David Gibson wrote: > > > On Mon, Aug 22, 2016 at 12:07:21PM +0200, Maxime Ripard wrote: > > > > Hi David, > > > >=20 > > > > On Mon, Aug 01, 2016 at 01:36:42PM +1000, David Gibson wrote: > > > > > On Fri, Jul 29, 2016 at 11:55:48AM +0200, Maxime Ripard wrote: > > > > > > Add a function to modify inplace only a portion of a property.. > > > > > >=20 > > > > > > This is especially useful when the property is an array of valu= es, and you > > > > > > want to update one of them without changing the DT size. > > > > > >=20 > > > > > > Acked-by: Simon Glass > > > > > > Reviewed-by: David Gibson > > > > > > Signed-off-by: Maxime Ripard > > > > >=20 > > > > > Applied, though I made a couple of tiny tweaks, see below. > > > >=20 > > > > Awesome, thanks! > > > >=20 > > > > Do you still have comments on the last 3 patches? > > >=20 > > > Sorry, I got sidetracked by other things. > > >=20 > > > The only remaining thing I'd like some changes in is the error > > > reporting. > > >=20 > > > The biggset problem is that in some places you are returning > > > BADSTRUCTURE for badly formatter fixup or other overlay properties. > > > BADSTRUCTURE should only be used when there is a problem in the > > > encoding of the tree structure itself, not a problem in the encoding > > > within a specific property or properties. > > >=20 > > > I don't think your code should ever generate BADSTRUCTURE directly > > > (but it could return it when it gets that value returned from a lower > > > level function). > > >=20 > > > What I was hoping to have a closer look at was to see if I'd prefer > > > just a single 'BADOVERLAY' error for any problem in te overlay > > > encoding, or if I'd prefer sveral: BADFIXUP, BADTARGET, or something > > > like that. I'll try to get a closer look, but it probably won't > > > happen this week (I'm at KVM Forum). > >=20 > > Did you have time to think about this? >=20 > Finally, yes. Just sent the detailed reply. I'll have a look, thanks! Expect a new version some time next week. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --M2XkPJ45YXpBrBm3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX5RnJAAoJEBx+YmzsjxAg8KUP/jITUcgrC4V4VrlSp0+WXKsA qZNNlnMBXBICHsNso5E/lj1bnC1Xjdm3jLUzxNAjS2/Mhp5r4ZcUTxKnoiEUQDuU 4hNo6B9np9MW5SpZ95jYuaTWe7KwhmqfwTzwOYM2ramDqUAVpJFOu5US4clK3ADA k5hDMQTJsTRlFcky5Oj0HVx0SJGHIEq+8kusweO91IJzkAvdtwloE2MrzYn20B69 PwKI7Agipz+ULa/6O6WpxAp5YGZvgZUu+dvQINg+1kxup7Mdoto2u5Jb7DIWUJye vJR2IKCLzA/8YUkjr2FdA4uDy6az+gvgvJdWdzMUv8ZYFQlrrJnGrFj4vJmpUNeL mOLjJ+9nHm2avqGtps5EJDcMZQWFVsTjw7KRAaIdXnxsRdBbuU2E76Y/NaEmsNEv Dp7LsoyoyvATbqV6Ybms9dLrJBgCrBwdtHkl+rLEZEq/8488uJzqEXsOYsiFEd5d 7S6QQRp2ipQrx8fqNvo39qz4zpI6192M8yloaAPrhq92ww+vc+C3VDRrd/ahnucB SnNkHNQv57+cVO9xKGqt9rDGl8InnGSVkVQzQ6lIINTPC3u+zTWt3sebqXHZKwrA 2yliE9k+ryfOgtncvUs0sStUEpa8Gr1aZBnfybmegM0yyzFGJ2WNMqI8WTNLlQEu oVWnB8McS36vpYNSyBBq =sM/c -----END PGP SIGNATURE----- --M2XkPJ45YXpBrBm3-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html