Re: [PATCH v2] Add a libfdt function to write a property placeholder

Re: [PATCH v2] Add a libfdt function to write a property placeholder

[Simon Glass]

Hi David,

On 24 October 2016 at 17:54, Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
> The existing function to add a new property to a tree being built requires
> that the entire contents of the new property be passed in. For some
> applications it is more convenient to be able to add the property contents
> later, perhaps by reading from a file. This avoids double-buffering of the
> contents.
>
> Add a new function to support this and adjust the existing fdt_property() to
> use it.
> Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
>
> Changes in v2:
> - Add tests
>
>  libfdt/fdt_sw.c                    | 16 ++++++++++++++--
>  libfdt/libfdt.h                    | 16 ++++++++++++++++
>  tests/include7.dts                 |  1 +
>  tests/sw_tree1.c                   |  5 +++++
>  tests/test_tree1.dts               |  1 +
>  tests/test_tree1_label_noderef.dts |  1 +
>  tests/trees.S                      |  2 ++
>  7 files changed, 40 insertions(+), 2 deletions(-)

Did you see this one?

Regards,
SImon

Re: [PATCH v2] Add a libfdt function to write a property placeholder

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]

On Tue, Nov 15, 2016 at 04:37:17PM -0700, Simon Glass wrote:
> Hi David,
> 
> On 24 October 2016 at 17:54, Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
> > The existing function to add a new property to a tree being built requires
> > that the entire contents of the new property be passed in. For some
> > applications it is more convenient to be able to add the property contents
> > later, perhaps by reading from a file. This avoids double-buffering of the
> > contents.
> >
> > Add a new function to support this and adjust the existing fdt_property() to
> > use it.
> > Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> > ---
> >
> > Changes in v2:
> > - Add tests
> >
> >  libfdt/fdt_sw.c                    | 16 ++++++++++++++--
> >  libfdt/libfdt.h                    | 16 ++++++++++++++++
> >  tests/include7.dts                 |  1 +
> >  tests/sw_tree1.c                   |  5 +++++
> >  tests/test_tree1.dts               |  1 +
> >  tests/test_tree1_label_noderef.dts |  1 +
> >  tests/trees.S                      |  2 ++
> >  7 files changed, 40 insertions(+), 2 deletions(-)
> 
> Did you see this one?

No, somehow I missed it.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]