From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Devicetree Compiler
<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/4] Add an initial Python library for libfdt
Date: Fri, 25 Nov 2016 09:03:09 +1100 [thread overview]
Message-ID: <20161124220309.GD23872@umbus.fritz.box> (raw)
In-Reply-To: <CAPnjgZ1=QTBNZa4G_uFpka3acr91ywH2P1QF8FJkfS-7Wpd5OQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2259 bytes --]
On Thu, Nov 24, 2016 at 11:08:00AM -0700, Simon Glass wrote:
> Hi David,
>
> On 17 November 2016 at 17:36, David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
> > On Thu, Nov 17, 2016 at 03:53:22PM -0700, Simon Glass wrote:
> >> Add Python bindings for a bare-bones set of libfdt functions. These allow
> >> navigating the tree and reading node names and properties.
> >
> > Nice idea. Some nits in the details..
> >
> >>
> >> Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> >> ---
> >>
> >> pylibfdt/.gitignore | 3 +
> >> pylibfdt/Makefile.pylibfdt | 21 ++++++
> >> pylibfdt/libfdt.swig | 157 +++++++++++++++++++++++++++++++++++++++++++++
> >> pylibfdt/setup.py | 34 ++++++++++
> >> 4 files changed, 215 insertions(+)
> >> create mode 100644 pylibfdt/.gitignore
> >> create mode 100644 pylibfdt/Makefile.pylibfdt
> >> create mode 100644 pylibfdt/libfdt.swig
> >> create mode 100644 pylibfdt/setup.py
> >>
> >> diff --git a/pylibfdt/.gitignore b/pylibfdt/.gitignore
> >> new file mode 100644
> >> index 0000000..5e8c5e3
> >> --- /dev/null
> >> +++ b/pylibfdt/.gitignore
> >> @@ -0,0 +1,3 @@
> >> +libfdt.py
> >> +libfdt.pyc
> >> +libfdt_wrap.c
> >> diff --git a/pylibfdt/Makefile.pylibfdt b/pylibfdt/Makefile.pylibfdt
> >> new file mode 100644
> >> index 0000000..fbdbca5
> >> --- /dev/null
> >> +++ b/pylibfdt/Makefile.pylibfdt
> >> @@ -0,0 +1,21 @@
> >> +# Makefile.pylibfdt
> >> +#
> >> +# This is not a complete Makefile of itself. Instead, it is designed to
> >> +# be easily embeddable into other systems of Makefiles.
> >
> > So, Makefile.libfdt is explicitly designed for easily embedding libfdt
> > in other projecs - even ones with weird build environments, like
> > bootloaders. It's less clear that that's valuable for Python
> > wrappers.
>
> OK, but what should i do instead?
Sorry, I just meant that that copied comment doesn't really make sense
in its entirity here. Otherwise the makefile is fine.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-11-24 22:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 22:53 [PATCH 0/4] Introduce Python bindings for libfdt Simon Glass
[not found] ` <1479423205-9817-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-11-17 22:53 ` [PATCH 1/4] Add an initial Python library " Simon Glass
[not found] ` <1479423205-9817-2-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-11-18 0:36 ` David Gibson
[not found] ` <20161118003645.GC31640-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2016-11-24 18:08 ` Simon Glass
[not found] ` <CAPnjgZ1=QTBNZa4G_uFpka3acr91ywH2P1QF8FJkfS-7Wpd5OQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-24 22:03 ` David Gibson [this message]
2016-11-17 22:53 ` [PATCH 2/4] Add tests for pylibfdt Simon Glass
2016-11-17 22:53 ` [PATCH 3/4] Mention pylibfdt in the documentation Simon Glass
2016-11-17 22:53 ` [PATCH 4/4] RFC: Build pylibfdt as part of the normal build process Simon Glass
-- strict thread matches above, loose matches on Subject: below --
2016-12-04 0:48 [PATCH v3 0/4] Introduce Python bindings for libfdt Simon Glass
2016-12-04 0:48 ` [PATCH v3 1/4] Add an initial Python library " Simon Glass
2016-12-05 4:35 ` David Gibson
2016-12-05 6:23 ` Simon Glass
2017-01-12 4:09 ` David Gibson
[not found] ` <20170112040950.GM14026-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2017-02-06 9:22 ` [PATCH " Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124220309.GD23872@umbus.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).