Re: Warnings do include offending filename

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2532 bytes --]

On Mon, Jan 30, 2017 at 09:13:05AM +0000, Ian Campbell wrote:
> Hello,
> 
> I wasn't sure how/where to make a wishlist bug report, so I hope this
> will suffice, am happy to be pointed in a different direction though.
> 
> I recently[0] stumbled over around 1,000 of these:
>     Warning (unit_address_vs_reg): Node /soc has a reg or ranges property, but no unit name
>     Warning (unit_address_vs_reg): Node /soc/main-oscillator has a reg or ranges property, but no unit name
>     Warning (unit_address_vs_reg): Node /soc has a reg or ranges property, but no unit name
>     Warning (unit_address_vs_reg): Node /soc has a reg or ranges property, but no unit name
>     Warning (unit_address_vs_reg): Node /soc/main-oscillator has a reg or ranges property, but no unit name
>     Warning (unit_address_vs_reg): Node /soc has a reg or ranges property, but no unit name
>     Warning (unit_address_vs_reg): Node /soc/main-oscillator has a reg or ranges property, but no unit name
> 
> When building the split device tree repo[1] from the Linux source
> (essential it's a build of every single dts in the kernel source).
> 
> The cause of the warning is an issue which needs to be fixed but I
> thought I would mention that it would be very useful (I expect) if dtc
> would include the offending file in warnings (like e.g. gcc would), not
> just because of the number of *.dtb being built here but also due to
> #include and /include/ of .dtsi files.

Right, having the filenames - and line numbers - there would certainly
be helpful.  Unfortunately, it's not at all trivial to implement.  As
someone said in a different thread, these checks take place (and have
to) after the tree is completely parsed and we no longer have source
locations readily to hand.

It might be possible to attach (optional) srcpos * markers to each
node and property in the live tree.  However, that runs into other
complications: when using dts includes nodes can be merges of
information from several different dtsi files.  So, a node can be
composed of information from several non-contiguous chunks of source
from different files.  It's not clear what should be printed in that
case.

If you can see a reasonable way to do this, I'd love to see patches
for it, but I certainly don't have time to tackle it myself.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]