From: Stephen Boyd <stephen.boyd@linaro.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: devicetree-compiler@vger.kernel.org,
Frank Rowand <frowand.list@gmail.com>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
Mark Rutland <mark.rutland@arm.com>,
mporter@konsulko.com, Koen Kooi <koen@dominion.thruhere.net>,
Guenter Roeck <linux@roeck-us.net>,
marex@denx.de, Wolfram Sang <wsa@the-dreams.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: [RFC/PATCH 2/4] dtc: Add syntactic sugar version of overlays
Date: Mon, 30 Jan 2017 16:02:57 -0800 [thread overview]
Message-ID: <20170131000259.28576-3-stephen.boyd@linaro.org> (raw)
In-Reply-To: <20170131000259.28576-1-stephen.boyd@linaro.org>
Instead of writing overlays with the target property and
__overlay__ node, i.e.
fragment@0 {
target = <&foo>;
__overlay__ {
bar-property = <0x200>;
};
}
support the syntactic sugar version of overlays where this can
be written as
&foo {
bar-property = <0x200>;
};
and have dtc convert that into a fragment node.
Based on a patch by Pantelis Antoniou.
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
---
dtc.c | 2 +-
dtc.h | 3 ++-
livetree.c | 40 ++++++++++++++++++++++++++++++++++++----
3 files changed, 39 insertions(+), 6 deletions(-)
diff --git a/dtc.c b/dtc.c
index 91e4c18b891e..d52d6c77a8cd 100644
--- a/dtc.c
+++ b/dtc.c
@@ -63,7 +63,7 @@ static void resolve_overlays(struct dt_info *dti)
struct overlay *o = dti->overlays;
while (o) {
- apply_overlay(dti->dt, o);
+ apply_overlay(dti->dt, o, dti->dtsflags);
o = o->next;
}
}
diff --git a/dtc.h b/dtc.h
index c4eb6421eabf..be75aac1f185 100644
--- a/dtc.h
+++ b/dtc.h
@@ -216,7 +216,8 @@ void append_to_property(struct node *node,
struct overlay *build_overlay(char *target, struct node *dt);
struct overlay *chain_overlay(struct overlay *first, struct overlay *list);
-void apply_overlay(struct node *base, struct overlay *overlay);
+void apply_overlay(struct node *base, struct overlay *overlay,
+ unsigned int dtsflags);
const char *get_unitname(struct node *node);
struct property *get_property(struct node *node, const char *propname);
diff --git a/livetree.c b/livetree.c
index dd51223d1e61..798a87ed587e 100644
--- a/livetree.c
+++ b/livetree.c
@@ -331,14 +331,46 @@ struct overlay *chain_overlay(struct overlay *first, struct overlay *list)
return first;
}
-void apply_overlay(struct node *base, struct overlay *overlay)
+static void add_fragment(struct node *base, struct overlay *overlay)
{
- struct node *target = get_node_by_ref(base, overlay->target);
+ static unsigned int next_fragment = 0;
+ struct node *node;
+ struct property *p;
+ struct data d = empty_data;
+ char *name;
- if (!target)
- die("Couldn't find label or path %s for overlay\n",
+ if (!overlay->dt)
+ die("Deletions not supported at runtime for %s\n",
overlay->target);
+ /* Insert a target = <&phandle> property */
+ d = data_add_marker(d, REF_PHANDLE, overlay->target);
+ d = data_append_integer(d, 0xffffffff, 32);
+
+ p = build_property("target", d);
+
+ xasprintf(&name, "fragment@%u", next_fragment++);
+ name_node(overlay->dt, "__overlay__");
+ node = build_node(p, overlay->dt);
+ name_node(node, name);
+
+ add_child(base, node);
+}
+
+void apply_overlay(struct node *base, struct overlay *overlay,
+ unsigned int dtsflags)
+{
+ struct node *target = get_node_by_ref(base, overlay->target);
+
+ if (!target) {
+ if (dtsflags & DTSF_PLUGIN) {
+ add_fragment(base, overlay);
+ return;
+ } else
+ die("Couldn't find label or path %s for overlay\n",
+ overlay->target);
+ }
+
if (!overlay->dt)
/* Deletion */
delete_node(target);
--
2.10.0.297.gf6727b0
next prev parent reply other threads:[~2017-01-31 0:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 0:02 [RFC/PATCH 0/4] New style overlay and /expansion/ support Stephen Boyd
2017-01-31 0:02 ` [RFC/PATCH 1/4] Start moving overlay handling from parser into dtc core Stephen Boyd
2017-01-31 0:02 ` Stephen Boyd [this message]
[not found] ` <20170131000259.28576-1-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-01-31 0:02 ` [RFC/PATCH 3/4] tests: Add a test for overlays syntactic sugar Stephen Boyd
2017-01-31 0:02 ` [RFC/PATCH 4/4] dtc: Add /expansion/ support Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131000259.28576-3-stephen.boyd@linaro.org \
--to=stephen.boyd@linaro.org \
--cc=broonie@kernel.org \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=koen@dominion.thruhere.net \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=mporter@konsulko.com \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).