From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
Cc: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org>,
Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH v2] libfdt: add helpers to read address and size from reg
Date: Fri, 10 Feb 2017 14:24:37 +1100 [thread overview]
Message-ID: <20170210032437.GI27610@umbus.fritz.box> (raw)
In-Reply-To: <7c83a816-a5a8-3529-623d-52cc6b9d5ed7-l0cyMroinI0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]
On Thu, Jan 26, 2017 at 11:31:53PM -0600, Nishanth Menon wrote:
> On 12/05/2016 05:11 PM, Benjamin Fair wrote:
> > This patch extends the capability of libfdt to parse the contents of device
> > trees in a similar manner to fdt_address_cells and fdt_size_cells.
> >
> > It adds helper functions which read the address and size of a device from
> > the reg property and performs basic sanity checks. Some functions also
> > parse the values into integers in the host endianness.
> >
> > The functions do not perform translation to a physical address using the
> > ranges properties of parents, but this enhancement may be added as a
> > separate function in the future.
> >
> > Signed-off-by: Benjamin Fair <b-fair-l0cyMroinI0@public.gmane.org>
> > ---
> >
> Hi David,
> Gentle ping.
> Benjamin is no longer with TI unfortunately(so dropped his mailid in reply),
> I believe this version addresses the comments you had. is there any thing
> additional to be done?
Sorry, I've been a mix of away and flat out with my day job. I'm
having a look now.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-02-10 3:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 23:11 [PATCH v2] libfdt: add helpers to read address and size from reg Benjamin Fair
[not found] ` <1480979490-3745-1-git-send-email-b-fair-l0cyMroinI0@public.gmane.org>
2017-01-27 5:31 ` Nishanth Menon
[not found] ` <7c83a816-a5a8-3529-623d-52cc6b9d5ed7-l0cyMroinI0@public.gmane.org>
2017-02-10 3:24 ` David Gibson [this message]
2017-02-06 15:32 ` Simon Glass
2017-02-10 3:37 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210032437.GI27610@umbus.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=d-gerlach-l0cyMroinI0@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jdl-CYoMK+44s/E@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).