From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Ian Campbell <ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Warnings do include offending filename
Date: Fri, 10 Feb 2017 15:11:22 +1100 [thread overview]
Message-ID: <20170210041122.GA25381@umbus> (raw)
In-Reply-To: <1486151046.7612.44.camel-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On Fri, Feb 03, 2017 at 07:44:06PM +0000, Ian Campbell wrote:
> On Thu, 2017-02-02 at 16:05 +1100, David Gibson wrote:
> > Feel free to send a patch and I'll think about it.
>
> Please see below.
>
> The diffstat is a rather large due to the need to plumb `outname`
> through to all the check functions. That could perhaps be avoided by
> adding it to `struct dt_info *dti` instead since that is already
> available in most places, but there would still be the churn relating
> to adding a parameter to `check_msg` and the various wrapper macros.
> Happy to rework along those lines if you prefer it though.
I think putting the output name into dt_info would be nicer, yes.
Make sure you allow for the case of output to stdout (which is default
for -I dtb -O dts).
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-02-10 4:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 9:13 Warnings do include offending filename Ian Campbell
[not found] ` <1485767585.7612.23.camel-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
2017-01-30 10:48 ` Ian Campbell
2017-01-30 23:49 ` David Gibson
[not found] ` <20170130234932.GB14879-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2017-01-31 8:24 ` Ian Campbell
[not found] ` <1485851088.7612.32.camel-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
2017-02-01 0:16 ` David Gibson
[not found] ` <20170201001654.GB30639-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2017-02-01 1:00 ` David Gibson
[not found] ` <20170201010004.GG30639-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2017-02-01 7:34 ` Ian Campbell
[not found] ` <1485934446.7612.36.camel-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
2017-02-02 5:05 ` David Gibson
[not found] ` <20170202050553.GF13219-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2017-02-03 19:44 ` Ian Campbell
[not found] ` <1486151046.7612.44.camel-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
2017-02-10 4:11 ` David Gibson [this message]
2017-02-19 16:00 ` Ian Campbell
[not found] ` <1487520043.7612.59.camel-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
2017-02-23 3:42 ` David Gibson
[not found] ` <20170223034219.GG12577-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2017-02-23 8:44 ` Ian Campbell
[not found] ` <1487839440.7612.76.camel-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
2017-02-23 9:13 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210041122.GA25381@umbus \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).