From: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Devicetree Compiler
<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>,
David Gibson
<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>,
Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: [PATCH 7/7] pylibfdt: Use the call function to simplify the Makefile
Date: Sun, 26 Mar 2017 13:06:23 -0600 [thread overview]
Message-ID: <20170326190623.27518-8-sjg@chromium.org> (raw)
In-Reply-To: <20170326190623.27518-1-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
This is in a separate patch since I not sure if GNU make features
are permitted in the Makefile.
Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
---
pylibfdt/Makefile.pylibfdt | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/pylibfdt/Makefile.pylibfdt b/pylibfdt/Makefile.pylibfdt
index a74cd30..0d95c11 100644
--- a/pylibfdt/Makefile.pylibfdt
+++ b/pylibfdt/Makefile.pylibfdt
@@ -5,11 +5,13 @@ PYLIBFDT_srcs = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_SRCS))
WRAP = $(PYLIBFDT_objdir)/libfdt_wrap.c
PYMODULE = $(PYLIBFDT_objdir)/_libfdt.so
+run_setup = SOURCES="$(1)" CPPFLAGS="$(CPPFLAGS)" OBJDIR="$(PYLIBFDT_objdir)" \
+ VERSION="$(dtc_version)" \
+ python $(PYLIBFDT_objdir)/setup.py --quiet $(2)
+
$(PYMODULE): $(PYLIBFDT_srcs) $(WRAP)
@$(VECHO) PYMOD $@
- SOURCES="$^" CPPFLAGS="$(CPPFLAGS)" OBJDIR="$(PYLIBFDT_objdir)" \
- VERSION="$(dtc_version)" \
- python $(PYLIBFDT_objdir)/setup.py --quiet build_ext --inplace
+ $(call run_setup, $^, build_ext --inplace)
$(WRAP): $(PYLIBFDT_srcdir)/libfdt.swig
@$(VECHO) SWIG $@
@@ -17,10 +19,8 @@ $(WRAP): $(PYLIBFDT_srcdir)/libfdt.swig
install_pylibfdt: $(WRAP) $(PYMODULE)
$(VECHO) INSTALL-PYLIB; \
- SOURCES="$(PYLIBFDT_srcs) $(WRAP)" CPPFLAGS="$(CPPFLAGS)" \
- OBJDIR="$(PYLIBFDT_objdir)" VERSION="$(dtc_version)" \
- python $(PYLIBFDT_objdir)/setup.py --quiet install \
- $(if $(SETUP_PREFIX),--prefix=$(SETUP_PREFIX))
+ $(call run_setup, $(PYLIBFDT_srcs) $(WRAP), \
+ install $(if $(SETUP_PREFIX),--prefix=$(SETUP_PREFIX)))
maybe_install_pylibfdt:
if [ -e $(PYMODULE) ]; then \
--
2.12.1.578.ge9c3154ca4-goog
next prev parent reply other threads:[~2017-03-26 19:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 19:06 [PATCH 0/7] pylibfdt: Add installation support Simon Glass
[not found] ` <20170326190623.27518-1-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-03-26 19:06 ` [PATCH 1/7] pylibfdt: Allow pkg-config to be supplied in the environment Simon Glass
[not found] ` <20170326190623.27518-2-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-03-27 4:28 ` David Gibson
2017-03-26 19:06 ` [PATCH 2/7] pylibfdt: Allow building to be disabled Simon Glass
[not found] ` <20170326190623.27518-3-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-03 18:41 ` Mike Frysinger
2017-04-05 3:28 ` Simon Glass
2017-03-26 19:06 ` [PATCH 3/7] pylibfdt: Use environment to pass C flags and files Simon Glass
[not found] ` <20170326190623.27518-4-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-03 18:42 ` Mike Frysinger
2017-04-05 3:28 ` Simon Glass
2017-03-26 19:06 ` [PATCH 4/7] pylibfdt: Use package_dir to set the package directory Simon Glass
2017-03-26 19:06 ` [PATCH 5/7] pylibfdt: Enable installation of Python module Simon Glass
[not found] ` <20170326190623.27518-6-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-03 18:43 ` Mike Frysinger
2017-04-05 3:27 ` Simon Glass
2017-03-26 19:06 ` [PATCH 6/7] pylibfdt: Use the correct libfdt version in the module Simon Glass
2017-03-26 19:06 ` Simon Glass [this message]
[not found] ` <20170326190623.27518-8-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-03 18:44 ` [PATCH 7/7] pylibfdt: Use the call function to simplify the Makefile Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170326190623.27518-8-sjg@chromium.org \
--to=sjg-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).