From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Devicetree Compiler
<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2 5/6] pylibfdt: Rename libfdt.swig to libfdt.i
Date: Mon, 3 Apr 2017 14:37:21 +1000 [thread overview]
Message-ID: <20170403043721.GD10997@umbus.fritz.box> (raw)
In-Reply-To: <20170329181541.28856-6-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]
On Wed, Mar 29, 2017 at 12:15:40PM -0600, Simon Glass wrote:
> The .i extension allows Python distutils to automatically handle the swig
> file. Rename it.
>
> Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Uh.. please don't. The existing Makefiles use %.i as a target for
preprocessed-but-not-compiled sources (occasionally useful for
debugging).
> ---
>
> Changes in v2:
> - Add new patch to rename libfdt.swig to libfdt.i
>
> pylibfdt/Makefile.pylibfdt | 2 +-
> pylibfdt/{libfdt.swig => libfdt.i} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename pylibfdt/{libfdt.swig => libfdt.i} (100%)
>
> diff --git a/pylibfdt/Makefile.pylibfdt b/pylibfdt/Makefile.pylibfdt
> index 0d95c11..06f9296 100644
> --- a/pylibfdt/Makefile.pylibfdt
> +++ b/pylibfdt/Makefile.pylibfdt
> @@ -13,7 +13,7 @@ $(PYMODULE): $(PYLIBFDT_srcs) $(WRAP)
> @$(VECHO) PYMOD $@
> $(call run_setup, $^, build_ext --inplace)
>
> -$(WRAP): $(PYLIBFDT_srcdir)/libfdt.swig
> +$(WRAP): $(PYLIBFDT_srcdir)/libfdt.i
> @$(VECHO) SWIG $@
> $(SWIG) -python -o $@ $<
>
> diff --git a/pylibfdt/libfdt.swig b/pylibfdt/libfdt.i
> similarity index 100%
> rename from pylibfdt/libfdt.swig
> rename to pylibfdt/libfdt.i
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-04-03 4:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 18:15 [PATCH v2 0/6] pylibfdt: Add installation support Simon Glass
[not found] ` <20170329181541.28856-1-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-03-29 18:15 ` [PATCH v2 1/6] pylibfdt: Allow building to be disabled Simon Glass
2017-03-29 18:15 ` [PATCH v2 2/6] pylibfdt: Enable installation of Python module Simon Glass
2017-03-29 18:15 ` [PATCH v2 3/6] pylibfdt: Use the correct libfdt version in the module Simon Glass
2017-03-29 18:15 ` [PATCH v2 4/6] pylibfdt: Use the call function to simplify the Makefile Simon Glass
2017-03-29 18:15 ` [PATCH v2 5/6] pylibfdt: Rename libfdt.swig to libfdt.i Simon Glass
[not found] ` <20170329181541.28856-6-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-03 4:37 ` David Gibson [this message]
[not found] ` <20170403043721.GD10997-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2017-04-05 3:18 ` Simon Glass
[not found] ` <CAPnjgZ3Bj5AY2nburGFmxScH7-Ws4R6sxWZQkqNW3NxNt5-5aQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-05 5:10 ` David Gibson
2017-03-29 18:15 ` [PATCH v2 6/6] pylibfdt: Allow setup.py to operation stand-alone Simon Glass
2017-03-29 18:16 ` [PATCH v2 0/6] pylibfdt: Add installation support Simon Glass
2017-04-03 4:37 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403043721.GD10997@umbus.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).