From: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Devicetree Compiler
<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
David Gibson
<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Subject: Re: [PATCH 3/7] pylibfdt: Use environment to pass C flags and files
Date: Mon, 3 Apr 2017 14:42:22 -0400 [thread overview]
Message-ID: <20170403184222.GY24205@vapier> (raw)
In-Reply-To: <20170326190623.27518-4-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On 26 Mar 2017 13:06, Simon Glass wrote:
> --- a/pylibfdt/Makefile.pylibfdt
> +++ b/pylibfdt/Makefile.pylibfdt
> @@ -7,7 +7,8 @@ PYMODULE = $(PYLIBFDT_objdir)/_libfdt.so
>
> $(PYMODULE): $(PYLIBFDT_srcs) $(WRAP)
> @$(VECHO) PYMOD $@
> - python $(PYLIBFDT_objdir)/setup.py "$(CPPFLAGS)" $^
> + SOURCES="$^" CPPFLAGS="$(CPPFLAGS)" \
> + python $(PYLIBFDT_objdir)/setup.py --quiet build_ext --inplace
you should make setup.py executable and drop the `python` call here
> +files = os.environ['SOURCES'].split()
you could parse this from the Makefile
> +cflags = os.environ['CPPFLAGS'].split()
this should be:
cflags = os.environ.get('CPPFLAGS', '').split()
> libfdt_module = Extension(
> '_libfdt',
> sources = files,
python style says to not put spaces around = when it comes to args
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-04-03 18:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 19:06 [PATCH 0/7] pylibfdt: Add installation support Simon Glass
[not found] ` <20170326190623.27518-1-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-03-26 19:06 ` [PATCH 1/7] pylibfdt: Allow pkg-config to be supplied in the environment Simon Glass
[not found] ` <20170326190623.27518-2-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-03-27 4:28 ` David Gibson
2017-03-26 19:06 ` [PATCH 2/7] pylibfdt: Allow building to be disabled Simon Glass
[not found] ` <20170326190623.27518-3-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-03 18:41 ` Mike Frysinger
2017-04-05 3:28 ` Simon Glass
2017-03-26 19:06 ` [PATCH 3/7] pylibfdt: Use environment to pass C flags and files Simon Glass
[not found] ` <20170326190623.27518-4-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-03 18:42 ` Mike Frysinger [this message]
2017-04-05 3:28 ` Simon Glass
2017-03-26 19:06 ` [PATCH 4/7] pylibfdt: Use package_dir to set the package directory Simon Glass
2017-03-26 19:06 ` [PATCH 5/7] pylibfdt: Enable installation of Python module Simon Glass
[not found] ` <20170326190623.27518-6-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-03 18:43 ` Mike Frysinger
2017-04-05 3:27 ` Simon Glass
2017-03-26 19:06 ` [PATCH 6/7] pylibfdt: Use the correct libfdt version in the module Simon Glass
2017-03-26 19:06 ` [PATCH 7/7] pylibfdt: Use the call function to simplify the Makefile Simon Glass
[not found] ` <20170326190623.27518-8-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-03 18:44 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403184222.GY24205@vapier \
--to=vapier-abrp7r+bbdudnm+yrofe0a@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).