From: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Devicetree Compiler
<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>,
David Gibson
<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>,
Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: [PATCH v3 2/5] pylibfdt: Fix code style in setup.py
Date: Wed, 5 Apr 2017 10:01:39 -0600 [thread overview]
Message-ID: <20170405160142.10564-3-sjg@chromium.org> (raw)
In-Reply-To: <20170405160142.10564-1-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
We should follow PEP8 even for our setup() call.
Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Suggested-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
---
Changes in v3:
- Add new patch to fix code style in setup.py
Changes in v2: None
pylibfdt/setup.py | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/pylibfdt/setup.py b/pylibfdt/setup.py
index 3bafe30..1597b44 100644
--- a/pylibfdt/setup.py
+++ b/pylibfdt/setup.py
@@ -24,11 +24,12 @@ libfdt_module = Extension(
extra_compile_args = cflags
)
-setup (name = 'libfdt',
- version = version,
- author = "Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>",
- description = """Python binding for libfdt""",
- ext_modules = [libfdt_module],
- package_dir = {'': objdir},
- py_modules = ["libfdt"],
- )
+setup(
+ name='libfdt',
+ version= version,
+ author='Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>',
+ description='Python binding for libfdt',
+ ext_modules=[libfdt_module],
+ package_dir={'': objdir},
+ py_modules=['libfdt'],
+)
--
2.12.2.715.g7642488e1d-goog
next prev parent reply other threads:[~2017-04-05 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 16:01 [PATCH v3 0/5] pylibfdt: Add installation support Simon Glass
[not found] ` <20170405160142.10564-1-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-05 16:01 ` [PATCH v3 1/5] pylibfdt: Rename libfdt.swig to libfdt.i Simon Glass
2017-04-05 16:01 ` Simon Glass [this message]
2017-04-05 16:01 ` [PATCH v3 3/5] pylibfdt: Allow setup.py to operate stand-alone Simon Glass
[not found] ` <20170405160142.10564-4-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-07 5:46 ` David Gibson
2017-04-07 21:48 ` Simon Glass
2017-04-05 16:01 ` [PATCH v3 4/5] pylibfdt: Use Makefile constructs to implement NO_PYTHON Simon Glass
2017-04-05 16:01 ` [PATCH v3 5/5] pylibfdt: Use setup.py to build the swig file Simon Glass
2017-04-07 5:49 ` [PATCH v3 0/5] pylibfdt: Add installation support David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405160142.10564-3-sjg@chromium.org \
--to=sjg-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).