devicetree-compiler.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix a few whitespace and style nits
@ 2017-04-08 16:14 Simon Glass
       [not found] ` <20170408161442.9064-1-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Simon Glass @ 2017-04-08 16:14 UTC (permalink / raw)
  To: Devicetree Compiler; +Cc: David Gibson, Simon Glass

These were noticed when synching with U-Boot's downstream tree.

Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
---

 libfdt/fdt_empty_tree.c | 1 -
 libfdt/fdt_ro.c         | 4 ++--
 libfdt/fdt_rw.c         | 4 ++--
 libfdt/fdt_wip.c        | 4 ++--
 4 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/libfdt/fdt_empty_tree.c b/libfdt/fdt_empty_tree.c
index f72d13b..f2ae9b7 100644
--- a/libfdt/fdt_empty_tree.c
+++ b/libfdt/fdt_empty_tree.c
@@ -81,4 +81,3 @@ int fdt_create_empty_tree(void *buf, int bufsize)
 
 	return fdt_open_into(buf, buf, bufsize);
 }
-
diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c
index 3d00d2e..08de2cc 100644
--- a/libfdt/fdt_ro.c
+++ b/libfdt/fdt_ro.c
@@ -60,7 +60,7 @@ static int _fdt_nodename_eq(const void *fdt, int offset,
 {
 	const char *p = fdt_offset_ptr(fdt, offset + FDT_TAGSIZE, len+1);
 
-	if (! p)
+	if (!p)
 		/* short match */
 		return 0;
 
@@ -327,7 +327,7 @@ const void *fdt_getprop_namelen(const void *fdt, int nodeoffset,
 	const struct fdt_property *prop;
 
 	prop = fdt_get_property_namelen(fdt, nodeoffset, name, namelen, lenp);
-	if (! prop)
+	if (!prop)
 		return NULL;
 
 	return prop->data;
diff --git a/libfdt/fdt_rw.c b/libfdt/fdt_rw.c
index 3fd5847..8b487f6 100644
--- a/libfdt/fdt_rw.c
+++ b/libfdt/fdt_rw.c
@@ -207,7 +207,7 @@ static int _fdt_resize_property(void *fdt, int nodeoffset, const char *name,
 	int err;
 
 	*prop = fdt_get_property_w(fdt, nodeoffset, name, &oldlen);
-	if (! (*prop))
+	if (!*prop)
 		return oldlen;
 
 	if ((err = _fdt_splice_struct(fdt, (*prop)->data, FDT_TAGALIGN(oldlen),
@@ -323,7 +323,7 @@ int fdt_delprop(void *fdt, int nodeoffset, const char *name)
 	FDT_RW_CHECK_HEADER(fdt);
 
 	prop = fdt_get_property_w(fdt, nodeoffset, name, &len);
-	if (! prop)
+	if (!prop)
 		return len;
 
 	proplen = sizeof(*prop) + FDT_TAGALIGN(len);
diff --git a/libfdt/fdt_wip.c b/libfdt/fdt_wip.c
index 6aaab39..5e85919 100644
--- a/libfdt/fdt_wip.c
+++ b/libfdt/fdt_wip.c
@@ -82,7 +82,7 @@ int fdt_setprop_inplace(void *fdt, int nodeoffset, const char *name,
 	int proplen;
 
 	propval = fdt_getprop(fdt, nodeoffset, name, &proplen);
-	if (! propval)
+	if (!propval)
 		return proplen;
 
 	if (proplen != len)
@@ -107,7 +107,7 @@ int fdt_nop_property(void *fdt, int nodeoffset, const char *name)
 	int len;
 
 	prop = fdt_get_property_w(fdt, nodeoffset, name, &len);
-	if (! prop)
+	if (!prop)
 		return len;
 
 	_fdt_nop_region(prop, len + sizeof(*prop));
-- 
2.12.2.715.g7642488e1d-goog

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix a few whitespace and style nits
       [not found] ` <20170408161442.9064-1-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
@ 2017-04-09 15:38   ` David Gibson
  0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2017-04-09 15:38 UTC (permalink / raw)
  To: Simon Glass; +Cc: Devicetree Compiler

[-- Attachment #1: Type: text/plain, Size: 3011 bytes --]

On Sat, Apr 08, 2017 at 10:14:42AM -0600, Simon Glass wrote:
> These were noticed when synching with U-Boot's downstream tree.
> 
> Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

Applied, thanks.

> ---
> 
>  libfdt/fdt_empty_tree.c | 1 -
>  libfdt/fdt_ro.c         | 4 ++--
>  libfdt/fdt_rw.c         | 4 ++--
>  libfdt/fdt_wip.c        | 4 ++--
>  4 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/libfdt/fdt_empty_tree.c b/libfdt/fdt_empty_tree.c
> index f72d13b..f2ae9b7 100644
> --- a/libfdt/fdt_empty_tree.c
> +++ b/libfdt/fdt_empty_tree.c
> @@ -81,4 +81,3 @@ int fdt_create_empty_tree(void *buf, int bufsize)
>  
>  	return fdt_open_into(buf, buf, bufsize);
>  }
> -
> diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c
> index 3d00d2e..08de2cc 100644
> --- a/libfdt/fdt_ro.c
> +++ b/libfdt/fdt_ro.c
> @@ -60,7 +60,7 @@ static int _fdt_nodename_eq(const void *fdt, int offset,
>  {
>  	const char *p = fdt_offset_ptr(fdt, offset + FDT_TAGSIZE, len+1);
>  
> -	if (! p)
> +	if (!p)
>  		/* short match */
>  		return 0;
>  
> @@ -327,7 +327,7 @@ const void *fdt_getprop_namelen(const void *fdt, int nodeoffset,
>  	const struct fdt_property *prop;
>  
>  	prop = fdt_get_property_namelen(fdt, nodeoffset, name, namelen, lenp);
> -	if (! prop)
> +	if (!prop)
>  		return NULL;
>  
>  	return prop->data;
> diff --git a/libfdt/fdt_rw.c b/libfdt/fdt_rw.c
> index 3fd5847..8b487f6 100644
> --- a/libfdt/fdt_rw.c
> +++ b/libfdt/fdt_rw.c
> @@ -207,7 +207,7 @@ static int _fdt_resize_property(void *fdt, int nodeoffset, const char *name,
>  	int err;
>  
>  	*prop = fdt_get_property_w(fdt, nodeoffset, name, &oldlen);
> -	if (! (*prop))
> +	if (!*prop)
>  		return oldlen;
>  
>  	if ((err = _fdt_splice_struct(fdt, (*prop)->data, FDT_TAGALIGN(oldlen),
> @@ -323,7 +323,7 @@ int fdt_delprop(void *fdt, int nodeoffset, const char *name)
>  	FDT_RW_CHECK_HEADER(fdt);
>  
>  	prop = fdt_get_property_w(fdt, nodeoffset, name, &len);
> -	if (! prop)
> +	if (!prop)
>  		return len;
>  
>  	proplen = sizeof(*prop) + FDT_TAGALIGN(len);
> diff --git a/libfdt/fdt_wip.c b/libfdt/fdt_wip.c
> index 6aaab39..5e85919 100644
> --- a/libfdt/fdt_wip.c
> +++ b/libfdt/fdt_wip.c
> @@ -82,7 +82,7 @@ int fdt_setprop_inplace(void *fdt, int nodeoffset, const char *name,
>  	int proplen;
>  
>  	propval = fdt_getprop(fdt, nodeoffset, name, &proplen);
> -	if (! propval)
> +	if (!propval)
>  		return proplen;
>  
>  	if (proplen != len)
> @@ -107,7 +107,7 @@ int fdt_nop_property(void *fdt, int nodeoffset, const char *name)
>  	int len;
>  
>  	prop = fdt_get_property_w(fdt, nodeoffset, name, &len);
> -	if (! prop)
> +	if (!prop)
>  		return len;
>  
>  	_fdt_nop_region(prop, len + sizeof(*prop));

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-09 15:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-08 16:14 [PATCH] Fix a few whitespace and style nits Simon Glass
     [not found] ` <20170408161442.9064-1-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-04-09 15:38   ` David Gibson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).