devicetree-compiler.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Tim Montague <tmontague-5j0BnJlmnLM@public.gmane.org>
Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] Fix get_node_by_path string equality check
Date: Wed, 19 Apr 2017 11:30:47 +1000	[thread overview]
Message-ID: <20170419013047.GE23273@umbus.fritz.box> (raw)
In-Reply-To: <7417379a9afc4272b5b62b8ff4e50719-xbOadlNgr96L7B8feK0ILA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1845 bytes --]

On Wed, Apr 19, 2017 at 01:15:08AM +0000, Tim Montague wrote:
>  > Ah.. it looks like your mailer has mangled the patch, I'm afraid:
> > 
> > $ git am -s ~/foobox/
> > Applying: Fix get_node_by_path string equality check
> > .git/rebase-apply/patch:16: trailing whitespace.
> > 		if (p && (strlen(child->name) == p-path) &&
> > .git/rebase-apply/patch:17: trailing whitespace.
> > 				strneq(path, child->name, p-path))
> > .git/rebase-apply/patch:30: trailing whitespace.
> > 	int n1, n2, n3, n4;
> > .git/rebase-apply/patch:38: trailing whitespace.
> > 	/* Check reference to nested nodes with common prefix */
> > .git/rebase-apply/patch:39: trailing whitespace.
> > 	n3 = fdt_path_offset(fdt, "/foo/baz");
> > error: patch failed: livetree.c:478
> > error: livetree.c: patch does not apply
> > error: patch failed: tests/path-references.c:66
> > error: tests/path-references.c: patch does not apply
> > error: patch failed: tests/path-references.dts:12
> > error: tests/path-references.dts: patch does not apply
> > Patch failed at 0001 Fix get_node_by_path string equality check
> > The copy of the patch that failed is found in: .git/rebase-apply/patch
> > When you have resolved this problem, run "git am --continue".
> > If you prefer to skip this patch, run "git am --skip" instead.
> > To restore the original branch and stop patching, run "git am --abort".
> > 
> > Can you check your mailer settings.  If it's not clear how to stop it
> > doing that, it's probably safe to attach the patch instead.
> 
> Sorry about that, Outlook doesn't always behave. The patch is attached.

Thanks, applied to master.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2017-04-19  1:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18  0:08 [PATCH] Fix get_node_by_path string equality check Tim Montague
     [not found] ` <f5424c7ce8334730a64873b9912132d3-xbOadlNgr96L7B8feK0ILA@public.gmane.org>
2017-04-18  2:05   ` David Gibson
     [not found]     ` <20170418020540.GA12235-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2017-04-18  3:18       ` Tim Montague
     [not found]         ` <77edbc7797e144cd9a635e5b1d0b2dfe-xbOadlNgr96L7B8feK0ILA@public.gmane.org>
2017-04-18  3:43           ` David Gibson
     [not found]             ` <20170418034332.GH12235-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2017-04-19  1:15               ` Tim Montague
     [not found]                 ` <7417379a9afc4272b5b62b8ff4e50719-xbOadlNgr96L7B8feK0ILA@public.gmane.org>
2017-04-19  1:30                   ` David Gibson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170419013047.GE23273@umbus.fritz.box \
    --to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
    --cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=tmontague-5j0BnJlmnLM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).