Re: [PATCH 2/3] fdtdump: Prettify output of properties

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2529 bytes --]

On Wed, Jun 14, 2017 at 10:12:54PM +0300, Pantelis Antoniou wrote:
> Hi David,
> 
> On Wed, 2017-06-14 at 23:06 +0800, David Gibson wrote:
> > On Wed, Jun 14, 2017 at 05:53:49PM +0300, Pantelis Antoniou wrote:
> > > Dumping files with large properties results in output with
> > > arbitrary long lines.
> > > 
> > > Original (manual line breaks inserted; it's a single long line):
> > > 
> > > / {
> > >     int = <0x00000001 0x00000024 0x00000004 0x00000000 \
> > > 0x000502a4 0x000000df 0x00000003 0x13885783 0x13885783 \
> > > 0x00000002 0x62797465 0x00000000 0x00000000 0x00000000 \
> > > 0x00000000 0x00000000 0x00000000 0x00000000 0x00000000 \
> > > 0x00000000 0x00000000 0x00000000 0x00000000 0x00000000>;
> > > };
> > > 
> > > After prettification:
> > > 
> > > / {
> > >     int = <0x00000001 0x00000002 0x00000008 0x00000010 0x00000024 0x000000ab>,
> > >           <0x00000001 0x00000017 0x00000004 0x00000038 0x00000007 0x00000009>,
> > >           <0x00000000 0x00000068 0x00000214 0x0000b8d9 0x000502a4 0x00000001>,
> > >           <0x00000004 0x0000002b 0x000000df 0x00000003 0x00000002 0x00000001>;
> > > };
> > > 
> > > There are two new options (-w/--width) and (-S/--shift).
> > > 
> > > Width is the terminal width, shift is the amount of spaces each nest level
> > > increases by.
> > > 
> > > Width by default is set to 80, and shift to 4.
> > 
> > Nack.
> > 
> > fdtdump is supposed to be a trivial debug tool.   If you want to
> > decompile dtbs "for real" use dtc -I dtb -O dts.
> > 
> 
> I'm afraid it's not so clear cut.
> 
> True, you can use dtc on the host to dump a blob to DTS in a similar
> manner to fdtdump (with the prettified output is much better with this
> patch).
> 
> Although the size of the dtc compiler package is larger than fdtdump by
> about 5 times (this is not that important nowdays), the biggest use is
> for restricted environment where the full dtc compiler just can't work.
> 
> A bootloader or something small can easily incorporate fdtdump for
> dumping out blobs, while including dtc is not even be possible.

Ok, but unlike libfdt, fdtdump will need at least minimal modification
to work in that restricted environment.  And if you're going to modify
it that way, you can add whatever pretty printing options you want.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]