* [PATCH] dtc: change default phandles to ePAPR style instead of both
@ 2017-07-12 22:20 Rob Herring
[not found] ` <20170712222030.22258-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2017-07-12 22:20 UTC (permalink / raw)
To: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
Currently, both legacy (linux,phandle) and ePAPR (phandle) properties
are inserted into dtbs by default. The newer ePAPR style has been
supported in dtc and Linux kernel for 7 years. That should be a long
enough transition period. We can save a little space by not putting both
into the dtb.
Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
dtc.c | 2 +-
tests/run_tests.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dtc.c b/dtc.c
index f5eed9d72c02..5ed873c72ad1 100644
--- a/dtc.c
+++ b/dtc.c
@@ -31,7 +31,7 @@ int reservenum; /* Number of memory reservation slots */
int minsize; /* Minimum blob size */
int padsize; /* Additional padding to blob */
int alignsize; /* Additional padding to blob accroding to the alignsize */
-int phandle_format = PHANDLE_BOTH; /* Use linux,phandle or phandle properties */
+int phandle_format = PHANDLE_EPAPR; /* Use linux,phandle or phandle properties */
int generate_symbols; /* enable symbols & fixup support */
int generate_fixups; /* suppress generation of fixups on symbol support */
int auto_label_aliases; /* auto generate labels -> aliases */
diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index 5df148048758..ccd301738726 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -420,7 +420,7 @@ dtc_tests () {
run_dtc_test -I dts -O dtb -o dtc_path-references.test.dtb path-references.dts
run_test path-references dtc_path-references.test.dtb
- run_test phandle_format dtc_references.test.dtb both
+ run_test phandle_format dtc_references.test.dtb epapr
for f in legacy epapr both; do
run_dtc_test -I dts -O dtb -H $f -o dtc_references.test.$f.dtb references.dts
run_test phandle_format dtc_references.test.$f.dtb $f
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dtc: change default phandles to ePAPR style instead of both
[not found] ` <20170712222030.22258-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2017-07-13 0:22 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2017-07-13 0:22 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 2189 bytes --]
On Wed, Jul 12, 2017 at 05:20:30PM -0500, Rob Herring wrote:
> Currently, both legacy (linux,phandle) and ePAPR (phandle) properties
> are inserted into dtbs by default. The newer ePAPR style has been
> supported in dtc and Linux kernel for 7 years. That should be a long
> enough transition period. We can save a little space by not putting both
> into the dtb.
>
> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Seems reasonable, applied.
> ---
> dtc.c | 2 +-
> tests/run_tests.sh | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dtc.c b/dtc.c
> index f5eed9d72c02..5ed873c72ad1 100644
> --- a/dtc.c
> +++ b/dtc.c
> @@ -31,7 +31,7 @@ int reservenum; /* Number of memory reservation slots */
> int minsize; /* Minimum blob size */
> int padsize; /* Additional padding to blob */
> int alignsize; /* Additional padding to blob accroding to the alignsize */
> -int phandle_format = PHANDLE_BOTH; /* Use linux,phandle or phandle properties */
> +int phandle_format = PHANDLE_EPAPR; /* Use linux,phandle or phandle properties */
> int generate_symbols; /* enable symbols & fixup support */
> int generate_fixups; /* suppress generation of fixups on symbol support */
> int auto_label_aliases; /* auto generate labels -> aliases */
> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
> index 5df148048758..ccd301738726 100755
> --- a/tests/run_tests.sh
> +++ b/tests/run_tests.sh
> @@ -420,7 +420,7 @@ dtc_tests () {
> run_dtc_test -I dts -O dtb -o dtc_path-references.test.dtb path-references.dts
> run_test path-references dtc_path-references.test.dtb
>
> - run_test phandle_format dtc_references.test.dtb both
> + run_test phandle_format dtc_references.test.dtb epapr
> for f in legacy epapr both; do
> run_dtc_test -I dts -O dtb -H $f -o dtc_references.test.$f.dtb references.dts
> run_test phandle_format dtc_references.test.$f.dtb $f
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-13 0:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-12 22:20 [PATCH] dtc: change default phandles to ePAPR style instead of both Rob Herring
[not found] ` <20170712222030.22258-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-07-13 0:22 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).