Re: [PATCH 3/5] checks: add string list check for *-names properties

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

On Fri, Nov 17, 2017 at 03:12:02PM +0000, Andre Przywara wrote:
> Hi,
> 
> On 17/11/17 14:45, Rob Herring wrote:
> > Add a string list check for common properties ending in "-names" such as
> > reg-names or interrupt-names.
> > 
> > Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > ---
> >  checks.c | 17 ++++++++++++++++-
> >  1 file changed, 16 insertions(+), 1 deletion(-)
> > 
> > diff --git a/checks.c b/checks.c
> > index 4e23f29486bb..346b0256f9cb 100644
> > --- a/checks.c
> > +++ b/checks.c
> > @@ -622,6 +622,21 @@ WARNING_IF_NOT_STRING(stdout_path_is_string, "stdout-path");
> >  
> >  WARNING_IF_NOT_STRING_LIST(compatible_is_string_list, "compatible");
> >  
> > +static void check_names_is_string_list(struct check *c, struct dt_info *dti,
> > +				       struct node *node)
> > +{
> > +	struct property *prop;
> > +
> > +	for_each_property(node, prop) {
> > +		if (!strstr(prop->name, "-names"))
> 
> But that would match "actually-names-dont-matter" as well, resulting in
> a false positive? Should we check if the string appears at the *end* of
> the property name?

Yes, we should.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]