Re: [PATCH] Improve compatibility with other platforms

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2440 bytes --]

On Tue, Jan 02, 2018 at 09:29:14PM -0600, Kyle Evans wrote:
> On Tue, Jan 2, 2018 at 8:58 PM, David Gibson
> <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
> > Fwiw, some years ago I did a bunch of work to get dtc to compile and
> > pass the tests on FreeBSD.  Working out of the box on *BSD is
> > something I'd like it to have.  Unfortunately, because I can't easily
> > test on a BSD machine, the BSD support tends to bitrot rather rapidly.
> 
> 
> Happy to hear this. =) You're not too far off, fortunately.

Good to hear.

> This, the
> alloca header situation, and an -ldl in tests/Makefile.tests are the
> only obstacles to being able to do a simple "gmake && gmake check"
> here. I've submitted patches for the first two, and as of r320872 [1]
> we provide a libdl on -HEAD.

Ok sounds good.  I had a look at the tests using -ldl and it looks
like they couldn't easily be adapted to avoid it.  However, I'd be ok
with logic to skip those tests if libdl isn't available, if you want
to broaden support to older releases.

At the moment dtc seems to be just teetering on the edge of being
complex enough to need some sort of configuration system (whether it
be hand-rolled scripts, autoconf or whatever).  So far I've been
avoiding adding such a thing, because that introduces a bunch of
problems of its own: hand rolled scripts are a pain to maintain,
autoconf is ugly as sin, pretty much anything else is nonstandard and
liable to introduce a bunch of extra dependencies.  But, I might have
to bite the bullet at some point.

> I will likely submit a patch in the near future to use `stat -f %Uz`
> automatically if stat --version exits with a non-zero exit code or
> indicates that it's GNU stat(1). This should cover the *BSDs, to
> include MacOS.

Great.  MacOS support is interesting in particular, because unlike
FreeBSD, I can set up a Travis build to test it there, which means I'm
much more likely to catch regressions.  In fact, looks like I have a
stale branch here that added an OSX build to the travis.yml - I think
some of the errors you've found and didn't have time to debug them
(debugging when your only host is indirect through Travis is pretty
painful).

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]