From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org
Cc: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Makefile.tests: Add LIBDL make(1) variable for portability sake
Date: Thu, 4 Jan 2018 15:37:25 +1100 [thread overview]
Message-ID: <20180104043725.GB24581@umbus.fritz.box> (raw)
In-Reply-To: <20180104043013.97083-1-kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]
On Wed, Jan 03, 2018 at 10:30:13PM -0600, kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org wrote:
> Some platforms (many, if not all, of the *BSD projects) do not provide a libdl,
> and instead provide the same functionality in libc. Instead of forcing these
> platforms to patch out the link against libdl, add a LIBDL make(1) variable to
> allow the -ldl argument to be excluded easily via make(1) arguments.
>
> Signed-off-by: Kyle Evans <kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
Applied, thanks.
> ---
> tests/Makefile.tests | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.tests b/tests/Makefile.tests
> index 2258135..262944a 100644
> --- a/tests/Makefile.tests
> +++ b/tests/Makefile.tests
> @@ -54,9 +54,12 @@ tests: $(TESTS) $(TESTS_TREES)
>
> $(LIB_TESTS): %: $(TESTS_PREFIX)testutils.o util.o $(LIBFDT_archive)
>
> +# Not necessary on all platforms; allow -ldl to be excluded instead of forcing
> +# other platforms to patch it out.
> +LIBDL = -ldl
> $(DL_LIB_TESTS): %: %.o $(TESTS_PREFIX)testutils.o util.o $(LIBFDT_archive)
> @$(VECHO) LD [libdl] $@
> - $(LINK.c) -o $@ $^ -ldl
> + $(LINK.c) -o $@ $^ $(LIBDL)
>
> $(LIBTREE_TESTS): %: $(TESTS_PREFIX)testutils.o $(TESTS_PREFIX)trees.o \
> util.o $(LIBFDT_archive)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-01-04 4:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 4:30 [PATCH] Makefile.tests: Add LIBDL make(1) variable for portability sake kevans-HZy0K5TPuP5AfugRpC6u6w
[not found] ` <20180104043013.97083-1-kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
2018-01-04 4:37 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104043725.GB24581@umbus.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jdl-CYoMK+44s/E@public.gmane.org \
--cc=kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).