From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org
Cc: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Makefile: Split INSTALL out into INSTALL_{PROGRAM,LIB,DATA,SCRIPT}
Date: Thu, 4 Jan 2018 18:25:00 +1100 [thread overview]
Message-ID: <20180104072500.GC24581@umbus.fritz.box> (raw)
In-Reply-To: <20180104034923.2919-1-kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2276 bytes --]
On Wed, Jan 03, 2018 at 09:49:23PM -0600, kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org wrote:
> For adoption into systems that may have additional arguments to be passed into
> install(1) upon install, split out INSTALL into the different types of files to
> be installed and use them appropriately. This allows, for instance, passing -s
> to strip binaries and libs while not botching directory installs or data/script
> installations.
>
> Signed-off-by: Kyle Evans <kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
Applied, thanks.
> ---
> Makefile | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9ba8121..5f1c274 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -26,6 +26,10 @@ SWIG = swig
> PKG_CONFIG ?= pkg-config
>
> INSTALL = /usr/bin/install
> +INSTALL_PROGRAM = $(INSTALL)
> +INSTALL_LIB = $(INSTALL)
> +INSTALL_DATA = $(INSTALL) -m 644
> +INSTALL_SCRIPT = $(INSTALL)
> DESTDIR =
> PREFIX = $(HOME)
> BINDIR = $(PREFIX)/bin
> @@ -191,20 +195,21 @@ endif
> install-bin: all $(SCRIPTS)
> @$(VECHO) INSTALL-BIN
> $(INSTALL) -d $(DESTDIR)$(BINDIR)
> - $(INSTALL) $(BIN) $(SCRIPTS) $(DESTDIR)$(BINDIR)
> + $(INSTALL_PROGRAM) $(BIN) $(DESTDIR)$(BINDIR)
> + $(INSTALL_SCRIPT) $(SCRIPTS) $(DESTDIR)$(BINDIR)
>
> install-lib: all
> @$(VECHO) INSTALL-LIB
> $(INSTALL) -d $(DESTDIR)$(LIBDIR)
> - $(INSTALL) $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
> + $(INSTALL_LIB) $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
> ln -sf $(notdir $(LIBFDT_lib)) $(DESTDIR)$(LIBDIR)/$(LIBFDT_soname)
> ln -sf $(LIBFDT_soname) $(DESTDIR)$(LIBDIR)/libfdt.$(SHAREDLIB_EXT)
> - $(INSTALL) -m 644 $(LIBFDT_archive) $(DESTDIR)$(LIBDIR)
> + $(INSTALL_DATA) $(LIBFDT_archive) $(DESTDIR)$(LIBDIR)
>
> install-includes:
> @$(VECHO) INSTALL-INC
> $(INSTALL) -d $(DESTDIR)$(INCLUDEDIR)
> - $(INSTALL) -m 644 $(LIBFDT_include) $(DESTDIR)$(INCLUDEDIR)
> + $(INSTALL_DATA) $(LIBFDT_include) $(DESTDIR)$(INCLUDEDIR)
>
> install: install-bin install-lib install-includes
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-01-04 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 3:49 [PATCH] Makefile: Split INSTALL out into INSTALL_{PROGRAM,LIB,DATA,SCRIPT} kevans-HZy0K5TPuP5AfugRpC6u6w
[not found] ` <20180104034923.2919-1-kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org>
2018-01-04 7:25 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104072500.GC24581@umbus.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jdl-CYoMK+44s/E@public.gmane.org \
--cc=kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).