From: Rob Herring <robh@kernel.org>
To: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
david@gibson.dropbear.id.au, sjg@chromium.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
devicetree-compiler@vger.kernel.org, Ian Lepore <ian@freebsd.org>
Subject: Re: [RFC PATCH v2 4/4] script: make automatic dtb build info generation
Date: Wed, 26 Feb 2020 14:56:14 -0600 [thread overview]
Message-ID: <20200226205614.GA15331@bogus> (raw)
In-Reply-To: <20200221161418.20225-5-alexandre.torgue@st.com>
On Fri, Feb 21, 2020 at 05:14:18PM +0100, Alexandre Torgue wrote:
> Append each "xxx.dtb.dts.tmp" file with "build-info" entry during dtb
> build. It allows to get build information (date, source version, ...)
> for each device tree without modify them manually.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index a5af84ef4ffc..f084e78267b2 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -289,6 +289,7 @@ quiet_cmd_dtc = DTC $@
> cmd_dtc = mkdir -p $(dir ${dtc-tmp}) ; \
> $(DTB_GEN_INFO) $(src) ; \
We regenerate this for every dtb?
> $(HOSTCC) -E $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
> + $(DTB_GEN_INFO) $(src) $(dtc-tmp) ; \
> $(DTC) -O $(2) -o $@ -b 0 \
> $(addprefix -i,$(dir $<) $(DTC_INCLUDE)) $(DTC_FLAGS) \
> -d $(depfile).dtc.tmp $(dtc-tmp) ; \
> diff --git a/scripts/gen_dtb_build_info.sh b/scripts/gen_dtb_build_info.sh
> index 0cd8bd98e410..72f31e386787 100755
> --- a/scripts/gen_dtb_build_info.sh
> +++ b/scripts/gen_dtb_build_info.sh
> @@ -6,5 +6,7 @@ set -o nounset
> DTB_DIR=$1
> DTB_COMPILE_BY=$(whoami | sed 's/\\/\\\\/')
Use LINUX_COMPILE_BY #define
> DTB_INFO="From Linux $KERNELRELEASE by $DTB_COMPILE_BY the $(date).\0"
I'd use UTS_RELEASE and UTS_VERSION defines here.
> +DTS_FILE=$2
>
> -printf "$DTB_INFO" > "$DTB_DIR/dtb-build.txt"
> +printf "$DTB_INFO" > "arch/arm/boot/dts/dtb-build.txt"
Obviously, hardcoding this is not right. You probably need to prepend
with $(obj) so this works for out of tree builds too.
> +echo "&{/} {build-info = /incbin/(\"dtb-build.txt\");};" >> $DTS_FILE
You could commit the .dtsi file using the above defines and then just
add a #include of it here. Then we'd get dependency tracking for free.
Rob
next prev parent reply other threads:[~2020-02-26 20:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 16:14 [RFC PATCH v2 0/4] Add device tree build information Alexandre Torgue
[not found] ` <20200221161418.20225-1-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
2020-02-21 16:14 ` [RFC PATCH v2 1/4] scripts: Add script to generate dtb " Alexandre Torgue
[not found] ` <20200221161418.20225-2-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
2020-02-21 17:52 ` Frank Rowand
[not found] ` <592e41a4-6115-474e-b6ce-eeb82f858a78-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-21 19:38 ` Rob Herring
2020-03-02 12:40 ` Alexandre Torgue
2020-02-23 21:59 ` David Gibson
2020-02-24 0:57 ` Frank Rowand
2020-02-21 16:14 ` [RFC PATCH v2 2/4] of: fdt: print " Alexandre Torgue
[not found] ` <20200221161418.20225-3-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
2020-02-26 21:36 ` Rob Herring
2020-02-21 16:14 ` [RFC PATCH v2 4/4] script: make automatic dtb build info generation Alexandre Torgue
2020-02-21 17:59 ` Frank Rowand
2020-02-26 20:56 ` Rob Herring [this message]
2020-02-21 17:47 ` [RFC PATCH v2 0/4] Add device tree build information Frank Rowand
2020-02-28 17:47 ` Frank Rowand
2020-03-02 12:55 ` Alexandre Torgue
[not found] ` <dba17be2-067f-8221-f313-7a3edcf61511-qxv4g6HH51o@public.gmane.org>
2020-03-31 1:03 ` Steve McIntyre
2020-03-31 15:00 ` Alexandre Torgue
2020-02-21 16:14 ` [RFC PATCH v2 3/4] ARM: dts: stm32: Add dtb build information entry for stm32mp157c-dk2 Alexandre Torgue
-- strict thread matches above, loose matches on Subject: below --
2020-02-21 16:12 [RFC PATCH v2 0/4] Alexandre Torgue
2020-02-21 16:12 ` [RFC PATCH v2 4/4] script: make automatic dtb build info generation Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226205614.GA15331@bogus \
--to=robh@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=ian@freebsd.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).