From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC PATCH v2 2/4] of: fdt: print dtb build information Date: Wed, 26 Feb 2020 15:36:38 -0600 Message-ID: <20200226213638.GA29417@bogus> References: <20200221161418.20225-1-alexandre.torgue@st.com> <20200221161418.20225-3-alexandre.torgue@st.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20200221161418.20225-3-alexandre.torgue-qxv4g6HH51o@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexandre Torgue Cc: Frank Rowand , Masahiro Yamada , Michal Marek , david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org, sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kbuild-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ian Lepore On Fri, Feb 21, 2020 at 05:14:16PM +0100, Alexandre Torgue wrote: > This commit prints out DTB build information (build time, dts source > version used, ...) if "Build-info" property exists in DTB root node. /Build/build/ > > Signed-off-by: Alexandre Torgue > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index 2cdf64d2456f..aa5989039746 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -1224,9 +1224,18 @@ bool __init early_init_dt_scan(void *params) > */ > void __init unflatten_device_tree(void) > { > + const char *build_info; > + unsigned long dt_root; > + > __unflatten_device_tree(initial_boot_params, NULL, &of_root, > early_init_dt_alloc_memory_arch, false); > > + /* If available, provide dtb build information */ > + dt_root = of_get_flat_dt_root(); > + build_info = of_get_flat_dt_prop(dt_root, "build-info", NULL); We just unflattened the tree, why are we using the flat dt functions? > + if (build_info) > + pr_info("%s\n", build_info); > + > /* Get pointer to "/chosen" and "/aliases" nodes for use everywhere */ > of_alias_scan(early_init_dt_alloc_memory_arch); > > -- > 2.17.1 >