From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Rothwell Subject: Re: linux-next: build warning after merge of the aspeed tree Date: Fri, 22 May 2020 10:16:38 +1000 Message-ID: <20200522101638.052bd0a2@canb.auug.org.au> References: <20200507091008.1bd38185@canb.auug.org.au> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/DcFF.Emc/VDOSRZyZQaAlh_"; protocol="application/pgp-signature"; micalg=pgp-sha256 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1590106600; bh=l28u3l9eD1XulIm/Ob3VyL9n6/znFRgaPoWiwdYuchM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T+kZWPqIDh1yLruVXvjSA0aAcEUeQfBa9mbmwsY0cTnpt9QxbzPW+V+DOjjJj8W9w QnGbExnmF6+8LPuS01E2FhHCTK1b4OEucxX9CSCGYg0mvRNytU8MYPlDOYFusIr1i6 b9G8tAwipE+fVmbYdzsgOpnRz1ZE99N/oHq1QJ9aGZgnYzWbADH+4YGVdboZKV2d6p sc/OUgjH0EROstM6Xk4lKImI6oyqADzhQS2bzIA0mXSyp2xhzas/TH/EIX9aAsaVEi kuOKleNXpeB/NrzyKWi/+O15u85EwuMb6il1PpdBawFdBZcEz6IzDY+xnpBHVKUdPc hV3bv0maYoTMg== In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: To: Olof Johansson , Arnd Bergmann , ARM Cc: Joel Stanley , Rob Herring , Arnd Bergmann , devicetree , Devicetree Compiler , Linux Next Mailing List , Linux Kernel Mailing List , Manikandan Elumalai , Andrew Jeffery , Vijay Khemka --Sig_/DcFF.Emc/VDOSRZyZQaAlh_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Wed, 20 May 2020 07:56:36 +0000 Joel Stanley wrote: > > On Mon, 11 May 2020 at 15:19, Rob Herring wrote: > > > > On Fri, May 8, 2020 at 1:40 AM Joel Stanley wrote: =20 > > > > > > On Wed, 6 May 2020 at 23:13, Joel Stanley wrote: =20 > > > > > > > > Hi Rob, > > > > > > > > On Wed, 6 May 2020 at 23:10, Stephen Rothwell wrote: =20 > > > > > > > > > > After merging the aspeed tree, today's linux-next build (arm > > > > > multi_v7_defconfig) produced this warning: =20 > > > > > > > > Thanks Stephen. > > > > =20 > > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:126.11-130.4= : Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10: I2C bus= unit address format error, expected "40000010" > > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:128.3-30: Wa= rning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:reg: I2C add= ress must be less than 10-bits, got "0x40000010" > > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:137.11-141.4= : Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@100/ipmb3@10: I2C bu= s unit address format error, expected "40000010" > > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:139.3-30: Wa= rning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@100/ipmb3@10:reg: I2C ad= dress must be less than 10-bits, got "0x40000010" > > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:148.11-152.4= : Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@180/ipmb5@10: I2C bu= s unit address format error, expected "40000010" > > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:150.3-30: Wa= rning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@180/ipmb5@10:reg: I2C ad= dress must be less than 10-bits, got "0x40000010" > > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:159.11-163.4= : Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@300/ipmb7@10: I2C bu= s unit address format error, expected "40000010" > > > > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:161.3-30: Wa= rning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@300/ipmb7@10:reg: I2C ad= dress must be less than 10-bits, got "0x40000010" =20 > > > > > > > > These are IPMB nodes with the SLAVE_ADDRESS bit set: > > > > > > > > +&i2c5 { > > > > + //Host3 IPMB bus > > > > + status =3D "okay"; > > > > + multi-master; > > > > + ipmb5@10 { > > > > + compatible =3D "ipmb-dev"; > > > > + reg =3D <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; > > > > + i2c-protocol; > > > > + }; > > > > > > > > This is a correct entry, so dtc should not warn about it. =20 > > > > > > I sent a patch for dtc here: > > > https://lore.kernel.org/lkml/20200508063904.60162-1-joel@jms.id.au/ = =20 > > > > Patches for dtc need to be against upstream dtc. There's already a > > similar patch posted for it which I commented on and never saw a > > respin. =20 >=20 > Can I suggest some instructions in scsripts/dtc explaining that you > don't take patches in the kernel tree for this code? >=20 > I've sent the patch so it applies to the dtc tree. It would be good to > see that change propagate over to -next as others have reported this > warning. These warnings now appear in the arm-soc tree. --=20 Cheers, Stephen Rothwell --Sig_/DcFF.Emc/VDOSRZyZQaAlh_ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl7HGeYACgkQAVBC80lX 0Gwm/gf/UiP3XqMc4FaiRIxc5sp/aEjFR3Yms5szHXC52VDyyQAv8DBKcjV6wFbC 6tANr+Lqsuu7loczGa7pvqcY7VdBlgk7dLKMDpQdVkgT0qcjiXYLp4w6hDJQO8vk +9ajzo1pJTIzTRV+b2AOOguhqsZyD/KzRqvkIU7EJW7WwKRFzPpQ9es70thQmSbG dMNZovADYWZEFGo/hpfnKlEmcdo0X3B5yzB4atAqrlaI4Y9JPDSaUiPney+V8uTP 8bjHyyk9Q9COdJOLqb5NPbK1WUWpXPWnqwTQI1fO7hRqaBx8Zopw8rc1DdW1NDbQ dmsqJlupAoog2jtPrusX7Ok7b7s8bA== =Gt6l -----END PGP SIGNATURE----- --Sig_/DcFF.Emc/VDOSRZyZQaAlh_--