From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Kumar Gala <kumar.gala-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: [PATCH 2/2] checks: Relax SPI slave checks
Date: Mon, 28 Sep 2020 15:19:42 -0500 [thread overview]
Message-ID: <20200928201942.3242124-2-robh@kernel.org> (raw)
In-Reply-To: <20200928201942.3242124-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
SPI slaves only have a single child node and therefore don't need
'#address-cells' nor '#size-cells', so let's skip the check for those when
'spi-slave' is present.
Cc: Kumar Gala <kumar.gala-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
checks.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/checks.c b/checks.c
index 17cb6890d45a..c923295c6e40 100644
--- a/checks.c
+++ b/checks.c
@@ -1102,13 +1102,12 @@ static void check_spi_bus_bridge(struct check *c, struct dt_info *dti, struct no
if (node->bus != &spi_bus || !node->children)
return;
- if (get_property(node, "spi-slave"))
- spi_addr_cells = 0;
- if (node_addr_cells(node) != spi_addr_cells)
- FAIL(c, dti, node, "incorrect #address-cells for SPI bus");
- if (node_size_cells(node) != 0)
- FAIL(c, dti, node, "incorrect #size-cells for SPI bus");
-
+ if (!get_property(node, "spi-slave")) {
+ if (node_addr_cells(node) != spi_addr_cells)
+ FAIL(c, dti, node, "incorrect #address-cells for SPI bus");
+ if (node_size_cells(node) != 0)
+ FAIL(c, dti, node, "incorrect #size-cells for SPI bus");
+ }
}
WARNING(spi_bus_bridge, check_spi_bus_bridge, NULL, &addr_size_cells);
--
2.25.1
next prev parent reply other threads:[~2020-09-28 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 20:19 [PATCH 1/2] checks: Allow PCI bridge child nodes without an address Rob Herring
[not found] ` <20200928201942.3242124-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-09-28 20:19 ` Rob Herring [this message]
[not found] ` <20200928201942.3242124-2-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-10-02 3:34 ` [PATCH 2/2] checks: Relax SPI slave checks David Gibson
2020-10-02 3:30 ` [PATCH 1/2] checks: Allow PCI bridge child nodes without an address David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928201942.3242124-2-robh@kernel.org \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kumar.gala-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).