Re: [PATCH 1/2] checks: Allow PCI bridge child nodes without an address

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

On Mon, Sep 28, 2020 at 03:19:41PM -0500, Rob Herring wrote:
> Some PCI bridge nodes have child nodes such as an interrupt controller
> which are not PCI devices. Allow these nodes which don't have a
> unit-address.
> 
> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

I suspect doing that isn't really IEEE1275-ly correct, but I can see
how that would be convenient.  Applied.

> ---
>  checks.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/checks.c b/checks.c
> index b7955dbd71ca..17cb6890d45a 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -891,10 +891,8 @@ static void check_pci_device_reg(struct check *c, struct dt_info *dti, struct no
>  		return;
>  
>  	prop = get_property(node, "reg");
> -	if (!prop) {
> -		FAIL(c, dti, node, "missing PCI reg property");
> +	if (!prop)
>  		return;
> -	}
>  
>  	cells = (cell_t *)prop->val.val;
>  	if (cells[1] || cells[2])

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]