From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Paul Barker <pbarker-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
Cc: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] tests: Fix overlay_overlay_nosugar test case
Date: Wed, 23 Dec 2020 17:04:39 +1100 [thread overview]
Message-ID: <20201223060439.GB4727@yekko.fritz.box> (raw)
In-Reply-To: <20201219143521.2118-1-pbarker-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2234 bytes --]
On Sat, Dec 19, 2020 at 02:35:21PM +0000, Paul Barker wrote:
> This test was accidentally skipped as the wrong test dts file was built.
> The fragment numbering in this sugar-free test case needed adjusting to
> match the numbering generated by dtc for overlay_overlay.dts.
>
> Signed-off-by: Paul Barker <pbarker-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
Applied, thanks.
> ---
> tests/overlay_overlay_nosugar.dts | 8 ++++----
> tests/run_tests.sh | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/overlay_overlay_nosugar.dts b/tests/overlay_overlay_nosugar.dts
> index b6d841b..b5947e9 100644
> --- a/tests/overlay_overlay_nosugar.dts
> +++ b/tests/overlay_overlay_nosugar.dts
> @@ -48,7 +48,7 @@
> };
> };
>
> - fragment@5 {
> + fragment@4 {
> target = <&test>;
>
> __overlay__ {
> @@ -58,7 +58,7 @@
> };
> };
>
> - fragment@6 {
> + fragment@5 {
> target = <&test>;
>
> __overlay__ {
> @@ -66,7 +66,7 @@
> };
> };
>
> - fragment@7 {
> + fragment@6 {
> target = <&test>;
>
> __overlay__ {
> @@ -74,7 +74,7 @@
> };
> };
>
> - fragment@8 {
> + fragment@7 {
> target = <&test>;
>
> __overlay__ {
> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
> index 294585b..4b8dada 100755
> --- a/tests/run_tests.sh
> +++ b/tests/run_tests.sh
> @@ -288,7 +288,7 @@ dtc_overlay_tests () {
> run_test check_path overlay_overlay.test.dtb exists "/__local_fixups__"
>
> # Without syntactic sugar
> - run_dtc_test -I dts -O dtb -o overlay_overlay_nosugar.test.dtb "$SRCDIR/overlay_overlay.dts"
> + run_dtc_test -I dts -O dtb -o overlay_overlay_nosugar.test.dtb "$SRCDIR/overlay_overlay_nosugar.dts"
> run_test check_path overlay_overlay_nosugar.test.dtb not-exists "/__symbols__"
> run_test check_path overlay_overlay_nosugar.test.dtb exists "/__fixups__"
> run_test check_path overlay_overlay_nosugar.test.dtb exists "/__local_fixups__"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-12-23 6:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 14:35 [PATCH] tests: Fix overlay_overlay_nosugar test case Paul Barker
[not found] ` <20201219143521.2118-1-pbarker-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2020-12-23 6:04 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223060439.GB4727@yekko.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jdl-CYoMK+44s/E@public.gmane.org \
--cc=pbarker-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).